-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Closed
Labels
PartnerResolution: LockedThis issue was locked by the bot.This issue was locked by the bot.Type: DiscussionLong running discussion.Long running discussion.p: ExpoPartner: ExpoPartner: Expo
Description
The Set & Map polyfills and EventEmitter under Libraries/vendor
use Haste. We can easily rewrite the imports in the vendored code, but we can make things easier for the next person who re-syncs the vendored code from the source by rewriting the imports in the pre-vendored code. (I could be mistaken about this, since Libraries/vendor/document/selection/DocumentSelectionState.js
uses path-based imports.)
There are two parts to this issue:
- Deciding whether to update the pre- or post-vendored code. We will update the post-vendored code.
Rewriting the imports inside of Facebook's source of truth (pre-vendored) orsubmitting a PR to rewrite only the code on GitHub (post-vendored).
matthargett
Metadata
Metadata
Assignees
Labels
PartnerResolution: LockedThis issue was locked by the bot.This issue was locked by the bot.Type: DiscussionLong running discussion.Long running discussion.p: ExpoPartner: ExpoPartner: Expo