Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$FlowFixMe - TODO T29156721 React.forwardRef is not defined in Flow, yet. #22595

Closed
3 tasks done
ggtmtmgg opened this issue Dec 11, 2018 · 2 comments
Closed
3 tasks done
Labels
Flow Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot. Type: Question Issues that are actually questions and not bug reports.

Comments

@ggtmtmgg
Copy link
Contributor

Description

I found this comment out and I'm wondering I should remove this comment out or fix something.

    // $FlowFixMe - TODO T29156721 `React.forwardRef` is not defined in Flow, yet.
    ViewToExport = React.forwardRef(View);
    ViewToExport.displayName = 'View';

https://github.com/facebook/react-native/blob/v0.58.0-rc.1/Libraries/Components/View/View.js#L50-L52

Because React.forwardRef()'s arguments are defined in React v16.6.3.

export default function forwardRef<Props, ElementType: React$ElementType>(
  render: (props: Props, ref: React$Ref<ElementType>) => React$Node,
) {

https://github.com/facebook/react/blob/v16.6.3/packages/react/src/forwardRef.js#L12-L14

May I have some info about this comment out? @yungsters

@ggtmtmgg ggtmtmgg added the Type: Question Issues that are actually questions and not bug reports. label Dec 11, 2018
@react-native-bot
Copy link
Collaborator

We are automatically closing this issue because it does not appear to follow any of the provided issue templates.

Please make use of the bug report template to let us know about a reproducible bug or regression in the core React Native library.

If you'd like to propose a change or discuss a feature request, there is a repository dedicated to Discussions and Proposals you may use for this purpose.

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. 📋No Template labels Dec 11, 2018
@evanjmg
Copy link

evanjmg commented May 4, 2019

I'm having a similar issue with typescript and react native

@facebook facebook locked as resolved and limited conversation to collaborators Dec 11, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Flow Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot. Type: Question Issues that are actually questions and not bug reports.
Projects
None yet
Development

No branches or pull requests

3 participants