Issue With iOS Custom Build Path

[kimihiro64]

• I have reviewed the documentation
• I have searched existing issues
• I am using the latest React Native version

react-native/local-cli/runIOS/runIOS.js

Line 30 in 48dccf1

return `build/Build/Products/${configuration}-${device}/${appName}.app`;

This line doesn't seem to be working properly if you've modified Per-Configuration Build Products path in XCode project settings. I've changed it so that my other configurations all use the same build path, Debug and Release, instead of their full configuration name (had issues with pods that wouldn't work otherwise). XCode will utilize build/Build/Products/Debug-iphonesimulator/appname.app during the build process (I'm not really sure where it gets this value from), but then the react-native script will try and use DebugProd-iphonesimulator and not find what XCode just built. Is there a way to make sure the path XCode is using is utilized by this script? Or would it be better to pull the per-configuration build path here and replace iphoneos with iphonesimulator if necessary? The former sounds like the better long term solution, but the latter is probably a quicker fix.

EDIT: In the export logs during build, this seems to be the var we should pull directly for the path if we have access to it:
BUILT_PRODUCTS_DIR = /Users/<user>/<project>/ios/build/Build/Products/Debug-iphonesimulator

Environment

Environment:
OS: macOS High Sierra 10.13.3
Node: 9.9.0
Yarn: 1.5.1
npm: 5.8.0
Watchman: 4.9.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.1 AI-173.4670197

Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: 0.52.0 => 0.52.0

Steps to Reproduce

1. Start with any out of the box application
2. Add a build configuration in XCode
3. Change the Per-Configuration Build Products Path in Build Locations settings in XCode for the added build configuration to anything besides the default $(BUILD_DIR)/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME) e.g. $(BUILD_DIR)/Debug$(EFFECTIVE_PLATFORM_NAME)
4. Add a scheme which builds the new configuration
5. react-native run-ios --scheme "$scheme" --configuration "$configuration"

Expected Behavior

run-ios should should load the .app bundle just built by XCode

Actual Behavior

run-ios is looking for the .app bundle in a different location than it was built

[react-native-bot]

It looks like your issue may refer to an older version of React Native. Can you reproduce the issue on the latest release, v0.55?

[kimihiro64]

The affected line of code is the same between 0.52 and 0.55, but I tried with latest just to be sure, still happens.

[stale]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

[stale]

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.