EXC_CORPSE_NOTIFY iOS crash when using native modules

[getaaron]

• I have reviewed the documentation
• I have searched existing issues
• I am using the latest React Native version

The app intermittently crashes when resolving or rejecting a promise in a native module. Possibly related to #5011.

This reproduces with several native modules so I don't think it's related to a specific module.

Environment

Environment:
  OS: macOS High Sierra 10.13.3
  Node: 9.5.0
  Yarn: 1.3.2
  npm: 5.6.0
  Watchman: 4.9.0
  Xcode: Xcode 9.2 Build version 9C40b
  Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed)
  react: ^16.3.0-alpha.1 => 16.3.0-alpha.3
  react-native: 0.55.0 => 0.55.0

Steps to Reproduce

1. Create a simple Native Module
2. Use it

Expected Behavior

I expect the data to flow back and forth as documented.

Actual Behavior

The app intermittently crashes with what looks like a memory issue.

From my observation I think it happens when resolving or rejecting a promise from Objective-C.

Here's a screenshot from the crash organizer. Note that the crash occurred on thread 10, not the main thread:

So it looks like it's somewhere in this code:

react-native/React/CxxModule/RCTNativeModule.mm

Lines 86 to 115 in 26684cf

	static MethodCallResult invokeInner(RCTBridge *bridge, RCTModuleData *moduleData, unsigned int methodId, const folly::dynamic &params) {
	if (!bridge || !bridge.valid || !moduleData) {
	return folly::none;
	}
	id<RCTBridgeMethod> method = moduleData.methods[methodId];
	if (RCT_DEBUG && !method) {
	RCTLogError(@"Unknown methodID: %ud for module: %@",
	methodId, moduleData.name);
	}
	NSArray *objcParams = convertFollyDynamicToId(params);
	@try {
	id result = [method invokeWithBridge:bridge module:moduleData.instance arguments:objcParams];
	return convertIdToFollyDynamic(result);
	}
	@catch (NSException *exception) {
	// Pass on JS exceptions
	if ([exception.name hasPrefix:RCTFatalExceptionName]) {
	@throw exception;
	}
	NSString *message = [NSString stringWithFormat:
	@"Exception '%@' was thrown while invoking %s on target %@ with params %@\ncallstack: %@",
	exception, method.JSMethodName, moduleData.name, objcParams, exception.callStackSymbols];
	RCTFatal(RCTErrorWithMessage(message));
	}
	return folly::none;
	}

I see that code can throw this exception:

Exception '%@' was thrown while invoking %s on target %@ with params %@\ncallstack: %@",
exception

But I don't see that error anywhere in the crash log so I'm not sure where to find it. I'm not sure if this was the actual exception, since the crash report says EXC_CORPSE_NOTIFY so it may be a red herring

[getaaron]

CC @philikon @mkonicek @bfarrgaynor @tadeuzagallo

[getaaron]

I was just able to reproduce what I think is the same issue in the simulator by pressing ⌘R a few times:

Interestingly, the stack trace is identical, but this says EXC_BAD_ACCESS vs. EXC_CORPSE_NOTIFY. I wonder if the difference is because the former is a debug build but the latter is a release build.

I tried to inspect some of the variables in lldb, but then Xcode crashed 🙄

[stale]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

[getaaron]

Issue still persists in 0.56

[JimBTek]

seems like we are seeing this:

OS Version:          iPhone OS 11.2 (15C114)
Baseband Version:    6.30.04
Report Version:      104

Exception Type:  EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Exception Note:  EXC_CORPSE_NOTIFY
Triggered by Thread:  21

Application Specific Information:
abort() called

Filtered syslog:
None found

Thread 21 name:  Dispatch queue: com.facebook.react.ExceptionsManagerQueue
Thread 21 Crashed:
0   libsystem_kernel.dylib        	0x00000001824282e8 __pthread_kill + 8
1   libsystem_pthread.dylib       	0x000000018253d2f8 pthread_kill$VARIANT$mp + 396
2   libsystem_c.dylib             	0x0000000182396fbc abort + 140
3   libc++abi.dylib               	0x0000000181b33068 __cxa_bad_cast + 0
4   libc++abi.dylib               	0x0000000181b33210 default_unexpected_handler+ 8720 () + 0
5   libobjc.A.dylib               	0x0000000181b5c810 _objc_terminate+ 34832 () + 124
6   OURApp Beta                  	0x000000010124e6ec 0x1011f0000 + 386796
7   libc++abi.dylib               	0x0000000181b4b54c std::__terminate(void (*)+ 107852 ()) + 16
8   libc++abi.dylib               	0x0000000181b4aea8 __cxxabiv1::exception_cleanup_func+ 106152 (_Unwind_Reason_Code, _Unwind_Exception*) + 0
9   libobjc.A.dylib               	0x0000000181b5c65c _objc_exception_destructor+ 34396 (void*) + 0
10  OURApp Beta                  	0x00000001012d9560 0x1011f0000 + 955744
11  OURApp Beta                  	0x00000001012d90a8 0x1011f0000 + 954536
12  libdispatch.dylib             	0x0000000182292a54 _dispatch_call_block_and_release + 24
13  libdispatch.dylib             	0x0000000182292a14 _dispatch_client_callout + 16
14  libdispatch.dylib             	0x000000018229c96c _dispatch_queue_serial_drain$VARIANT$mp + 528
15  libdispatch.dylib             	0x000000018229d2fc _dispatch_queue_invoke$VARIANT$mp + 340
16  libdispatch.dylib             	0x000000018229dd20 _dispatch_root_queue_drain_deferred_wlh$VARIANT$mp + 404
17  libdispatch.dylib             	0x00000001822a603c _dispatch_workloop_worker_thread$VARIANT$mp + 644
18  libsystem_pthread.dylib       	0x000000018253af1c _pthread_wqthread + 932
19  libsystem_pthread.dylib       	0x000000018253ab6c start_wqthread + 4

[skrilladeville]

Good Work Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Jim Bartek <notifications@github.com> Sent: Friday, September 21, 2018 4:38:24 PM To: facebook/react-native Cc: Subscribed Subject: Re: [facebook/react-native] EXC_CORPSE_NOTIFY iOS crash when using native modules (#19107) seems like we are seeing this: OS Version: iPhone OS 11.2 (15C114) Baseband Version: 6.30.04 Report Version: 104 Exception Type: EXC_CRASH (SIGABRT) Exception Codes: 0x0000000000000000, 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY Triggered by Thread: 21 Application Specific Information: abort() called Filtered syslog: None found Thread 21 name: Dispatch queue: com.facebook.react.ExceptionsManagerQueue Thread 21 Crashed: 0 libsystem_kernel.dylib 0x00000001824282e8 __pthread_kill + 8 1 libsystem_pthread.dylib 0x000000018253d2f8 pthread_kill$VARIANT$mp + 396 2 libsystem_c.dylib 0x0000000182396fbc abort + 140 3 libc++abi.dylib 0x0000000181b33068 __cxa_bad_cast + 0 4 libc++abi.dylib 0x0000000181b33210 default_unexpected_handler+ 8720 () + 0 5 libobjc.A.dylib 0x0000000181b5c810 _objc_terminate+ 34832 () + 124 6 TechApp Beta 0x000000010124e6ec 0x1011f0000 + 386796 7 libc++abi.dylib 0x0000000181b4b54c std::__terminate(void (*)+ 107852 ()) + 16 8 libc++abi.dylib 0x0000000181b4aea8 __cxxabiv1::exception_cleanup_func+ 106152 (_Unwind_Reason_Code, _Unwind_Exception*) + 0 9 libobjc.A.dylib 0x0000000181b5c65c _objc_exception_destructor+ 34396 (void*) + 0 10 TechApp Beta 0x00000001012d9560 0x1011f0000 + 955744 11 TechApp Beta 0x00000001012d90a8 0x1011f0000 + 954536 12 libdispatch.dylib 0x0000000182292a54 _dispatch_call_block_and_release + 24 13 libdispatch.dylib 0x0000000182292a14 _dispatch_client_callout + 16 14 libdispatch.dylib 0x000000018229c96c _dispatch_queue_serial_drain$VARIANT$mp + 528 15 libdispatch.dylib 0x000000018229d2fc _dispatch_queue_invoke$VARIANT$mp + 340 16 libdispatch.dylib 0x000000018229dd20 _dispatch_root_queue_drain_deferred_wlh$VARIANT$mp + 404 17 libdispatch.dylib 0x00000001822a603c _dispatch_workloop_worker_thread$VARIANT$mp + 644 18 libsystem_pthread.dylib 0x000000018253af1c _pthread_wqthread + 932 19 libsystem_pthread.dylib 0x000000018253ab6c start_wqthread + 4 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#19107 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADe8y0qY1BVl5pObSlXQQvDlxLdp-RtBks5udVxQgaJpZM4TwA4P>.

[skrilladeville]

Good work good work good work good work good work good work Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Jim Bartek <notifications@github.com> Sent: Friday, September 21, 2018 4:38:24 PM To: facebook/react-native Cc: Subscribed Subject: Re: [facebook/react-native] EXC_CORPSE_NOTIFY iOS crash when using native modules (#19107) seems like we are seeing this: OS Version: iPhone OS 11.2 (15C114) Baseband Version: 6.30.04 Report Version: 104 Exception Type: EXC_CRASH (SIGABRT) Exception Codes: 0x0000000000000000, 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY Triggered by Thread: 21 Application Specific Information: abort() called Filtered syslog: None found Thread 21 name: Dispatch queue: com.facebook.react.ExceptionsManagerQueue Thread 21 Crashed: 0 libsystem_kernel.dylib 0x00000001824282e8 __pthread_kill + 8 1 libsystem_pthread.dylib 0x000000018253d2f8 pthread_kill$VARIANT$mp + 396 2 libsystem_c.dylib 0x0000000182396fbc abort + 140 3 libc++abi.dylib 0x0000000181b33068 __cxa_bad_cast + 0 4 libc++abi.dylib 0x0000000181b33210 default_unexpected_handler+ 8720 () + 0 5 libobjc.A.dylib 0x0000000181b5c810 _objc_terminate+ 34832 () + 124 6 TechApp Beta 0x000000010124e6ec 0x1011f0000 + 386796 7 libc++abi.dylib 0x0000000181b4b54c std::__terminate(void (*)+ 107852 ()) + 16 8 libc++abi.dylib 0x0000000181b4aea8 __cxxabiv1::exception_cleanup_func+ 106152 (_Unwind_Reason_Code, _Unwind_Exception*) + 0 9 libobjc.A.dylib 0x0000000181b5c65c _objc_exception_destructor+ 34396 (void*) + 0 10 TechApp Beta 0x00000001012d9560 0x1011f0000 + 955744 11 TechApp Beta 0x00000001012d90a8 0x1011f0000 + 954536 12 libdispatch.dylib 0x0000000182292a54 _dispatch_call_block_and_release + 24 13 libdispatch.dylib 0x0000000182292a14 _dispatch_client_callout + 16 14 libdispatch.dylib 0x000000018229c96c _dispatch_queue_serial_drain$VARIANT$mp + 528 15 libdispatch.dylib 0x000000018229d2fc _dispatch_queue_invoke$VARIANT$mp + 340 16 libdispatch.dylib 0x000000018229dd20 _dispatch_root_queue_drain_deferred_wlh$VARIANT$mp + 404 17 libdispatch.dylib 0x00000001822a603c _dispatch_workloop_worker_thread$VARIANT$mp + 644 18 libsystem_pthread.dylib 0x000000018253af1c _pthread_wqthread + 932 19 libsystem_pthread.dylib 0x000000018253ab6c start_wqthread + 4 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#19107 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADe8y0qY1BVl5pObSlXQQvDlxLdp-RtBks5udVxQgaJpZM4TwA4P>.

[skrilladeville]

GovLoop Get Outlook for Android<https://aka.ms/ghei36> From: Jim Bartek Sent: Friday, September 21, 4:38 PM Subject: Re: [facebook/react-native] EXC_CORPSE_NOTIFY iOS crash when using native modules (#19107) To: facebook/react-native Cc: Subscribed seems like we are seeing this: OS Version: iPhone OS 11.2 (15C114) Baseband Version: 6.30.04 Report Version: 104 Exception Type: EXC_CRASH (SIGABRT) Exception Codes: 0x0000000000000000, 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY Triggered by Thread: 21 Application Specific Information: abort() called Filtered syslog: None found Thread 21 name: Dispatch queue: com.facebook.react.ExceptionsManagerQueue Thread 21 Crashed: 0 libsystem_kernel.dylib 0x00000001824282e8 __pthread_kill + 8 1 libsystem_pthread.dylib 0x000000018253d2f8 pthread_kill$VARIANT$mp + 396 2 libsystem_c.dylib 0x0000000182396fbc abort + 140 3 libc++abi.dylib 0x0000000181b33068 __cxa_bad_cast + 0 4 libc++abi.dylib 0x0000000181b33210 default_unexpected_handler+ 8720 () + 0 5 libobjc.A.dylib 0x0000000181b5c810 _objc_terminate+ 34832 () + 124 6 TechApp Beta 0x000000010124e6ec 0x1011f0000 + 386796 7 libc++abi.dylib 0x0000000181b4b54c std::__terminate(void (*)+ 107852 ()) + 16 8 libc++abi.dylib 0x0000000181b4aea8 __cxxabiv1::exception_cleanup_func+ 106152 (_Unwind_Reason_Code, _Unwind_Exception*) + 0 9 libobjc.A.dylib 0x0000000181b5c65c _objc_exception_destructor+ 34396 (void*) + 0 10 TechApp Beta 0x00000001012d9560 0x1011f0000 + 955744 11 TechApp Beta 0x00000001012d90a8 0x1011f0000 + 954536 12 libdispatch.dylib 0x0000000182292a54 _dispatch_call_block_and_release + 24 13 libdispatch.dylib 0x0000000182292a14 _dispatch_client_callout + 16 14 libdispatch.dylib 0x000000018229c96c _dispatch_queue_serial_drain$VARIANT$mp + 528 15 libdispatch.dylib 0x000000018229d2fc _dispatch_queue_invoke$VARIANT$mp + 340 16 libdispatch.dylib 0x000000018229dd20 _dispatch_root_queue_drain_deferred_wlh$VARIANT$mp + 404 17 libdispatch.dylib 0x00000001822a603c _dispatch_workloop_worker_thread$VARIANT$mp + 644 18 libsystem_pthread.dylib 0x000000018253af1c _pthread_wqthread + 932 19 libsystem_pthread.dylib 0x000000018253ab6c start_wqthread + 4 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#19107 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADe8y0qY1BVl5pObSlXQQvDlxLdp-RtBks5udVxQgaJpZM4TwA4P>.

[gerow-x]

+1

[Mubashirkhan]

has some one fixed this issue ??????