Description
Issue Description
-
This happens when users have images stored in iCloud
-
This doesn't happen with images stored in the device.
-
For some users, CameraRoll.getPhotos is crashing for some specific files, the crash report doesn't display any information of the image, so it's difficult to find the issue.
-
This error doesn't happen to all users.
-
A similar issue has been reported before: iOS: Fix Crash when CameraRoll is getting assets from iCloud and no filename is provided. #13671 #17549 but this update wasn't included in react-native: 0.53.3 => 0.53.3
Anyway, I did this update manually, you can see it in the attached screenshot: https://github.com/facebook/react-native/pull/17549/files#diff-8aeecd9754b31530870848234a6a6386R202
And seems that this update fixed some cases, but not all of them, because the app is still crashing with some iCloud files.
Environment
Environment:
OS: macOS High Sierra 10.13.3
Node: 7.9.0
Yarn: 0.23.2
npm: 5.5.1
Watchman: 4.7.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 2.3 AI-162.4069837
Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: 0.53.3 => 0.53.3
Expected Behavior
CameraRoll.getPhotos should return local and iCloud images
Actual Behavior
CameraRoll.getPhotos crashes trying to get iCloud photos
Steps to Reproduce
This error happens to some users only.
Happens only with iCloud Photos
Use the expo app to load your icloud photos. The crash could happen with a random image.
Expo App:
https://exp.host/@facuescobar/camera-roll-photos-2018
Code:
https://github.com/facuescobar/camera-roll-photos
CameraRoll.getPhotos params:
https://github.com/facuescobar/camera-roll-photos/blob/master/src/reducers/camera-roll.js#L20
CameraRoll.getPhotos call:
https://github.com/facuescobar/camera-roll-photos/blob/master/src/actions/camera-roll.js#L20
https://github.com/facuescobar/camera-roll-photos/blob/master/src/actions/camera-roll.js#L46