Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking.openURL behavior is not consistent with documentation #17484

Closed
jaycanty opened this issue Jan 8, 2018 · 5 comments
Closed

Linking.openURL behavior is not consistent with documentation #17484

jaycanty opened this issue Jan 8, 2018 · 5 comments
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@jaycanty
Copy link

jaycanty commented Jan 8, 2018

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Steps to Reproduce

(Write your steps here:)

  1. Click button that calls Linking.openURL
  2. Wait for Confirm/Cancel popup
  3. Press Cancel

Expected Behavior

Expect: Linking.openURL should reject

Actual Behavior

Actual: Linking.openURL resolves

Reproducible Demo

Steps to recreate:

  • react-native init LinkTest
  • In App.js render add;
        <TouchableOpacity onPress={this.onPress}>
          <Text>
            Link
          </Text>
        </TouchableOpacity>

and in App class;

  onPress = () => {
      const link = 'tel:2125551212'
      Linking.openURL(link)
          .then(() =>  {
              console.log('CONFIRM')
          })
          .catch(() => {
              console.log('CANCEL')
          })
  }

No repo included due to this needing to be run on a device to test

@react-native-bot
Copy link
Collaborator

Thanks for posting this! It looks like you may not be using the latest version of React Native, v0.53.0, released on January 2018. Can you make sure this issue can still be reproduced in the latest version?

I am going to close this, but please feel free to open a new issue if you are able to confirm that this is still a problem in v0.53.0 or newer.

How to ContributeWhat to Expect from Maintainers

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon. labels Feb 24, 2018
@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Feb 24, 2018
@treemore
Copy link

i was test in react-native 0.55.3 and 0.55.4 . and i am sure Linking.openURL behavior is not consistent with documentation .
whenever your choice confirm or cancel . the promise resolve will be done .

@TNicholson11
Copy link

Anyone have a fix or workaround for this? I'm also in need of the callback from the Confirm/Cancel system dialog.

@guojindai
Copy link

this issuer still exists in 0.57.5

@Zvukamar
Copy link

+1

@facebook facebook locked as resolved and limited conversation to collaborators Feb 24, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Feb 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

6 participants