Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][SwipeableFlatList] First item not updated for the first time. Second, third... OK #16685

Closed
kesha-antonov opened this issue Nov 5, 2017 · 7 comments
Labels
Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@kesha-antonov
Copy link
Contributor

kesha-antonov commented Nov 5, 2017

Hello!

If you pass updated data to SwipeableFlatList for the first time - item at index 0 will not be updated. On second, third etc. item updated as expected.

Also if you pass updated data to SwipeableFlatList for the first time item at index higher than 0 they'll be updated as expected.

Some weird bug.

For now I just update data 2 times at one time just to be sure.

Is this a bug report?

Yes.

Have you read the Contributing Guidelines?

Yes.

Environment

Environment:
  OS: macOS High Sierra 10.13
  Node: 6.11.3
  Yarn: 1.3.2
  npm: 5.4.2
  Watchman: 4.9.0
  Xcode: Xcode 9.0 Build version 9A235
  Android Studio: 3.0 AI-171.4408382

Packages: (wanted => installed)
  react: 16.0.0 => 16.0.0
  react-native: github:kesha-antonov/react-native#master_with_videos_5_11_2017 => 1000.0.0

Steps to Reproduce

  1. Create SwipeableFlatList with 2 items
<SwipeableFlatList
  data={this.props.data}
  renderItem={this.renderItem}
  keyExtractor={this.keyExtractor}
/>
  1. Pass updated data with updated only first item to List
  2. See no updates

Expected Behavior

First item should be updated.

Actual Behavior

First item not updated.

Reproducible Demo

Tried to reproduce with Snack but SwipeableFlatList is not on npm yet?
https://snack.expo.io/BJnvHq3AZ?session_id=snack-session-BJxUFSchRW

@kesha-antonov
Copy link
Contributor Author

cc
@tomasreimers
@sahrens

@kesha-antonov
Copy link
Contributor Author

Also here's one fix for another issue with SwipeableFlatList
#16682

@tomasreimers
Copy link
Contributor

@kesha-antonov are you still finding this issue? And have you found any fixes?

@kesha-antonov
Copy link
Contributor Author

My PR fixed issues. @tomasreimers

@stale
Copy link

stale bot commented Feb 15, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Feb 15, 2018
@kesha-antonov
Copy link
Contributor Author

!

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Feb 16, 2018
@react-native-bot
Copy link
Collaborator

Thanks for posting this! It looks like you may not be using the latest version of React Native, v0.53.0, released on January 2018. Can you make sure this issue can still be reproduced in the latest version?

I am going to close this, but please feel free to open a new issue if you are able to confirm that this is still a problem in v0.53.0 or newer.

How to ContributeWhat to Expect from Maintainers

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon. labels Feb 24, 2018
@facebook facebook locked and limited conversation to collaborators May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
3 participants