[RN 0.48.3 Xcode 9] RCTImageStoreManager: Semantic Issue

[delef]

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Environment:
OS: macOS Sierra 10.12.6
Node: 8.4.0
Yarn: Not Found
npm: 5.4.2
Watchman: 4.7.0
Xcode: Xcode 9.0 Build version 9A235
Android Studio: 2.1 AI-143.3101438

Packages: (wanted => installed)
react: 16.0.0-alpha.12 => 16.0.0-alpha.12
react-native: ^0.48.3 => 0.48.3

Steps to Reproduce

1. react-native init test
2. Install latest xcode version
3. Open ~/test/ios/test.xcodeproj (xcode)
4. Update to recommended settings (for all xcodeproj)
5. Build

Expected Behavior

The project started with the old version of xcode.

Actual Behavior

"This block declaration is not a prototype"

Reproducible Demo

https://github.com/delef/rn-xcode9

[SupriyaAdep]

Facing similar issue

[ragamufin]

You can try:

https://stackoverflow.com/a/44473380/577280

[michaelmerrill]

Having this issue as well. RN 0.48.4, RCT 16.0.0-rc.3.

[glebovitz]

Having this issue as well.

[Evaske]

Also having this issue. Can't get it to run on a device. Build fails with the above error.

[glebovitz]

I got my code to compile. The offending code is the prototype for the blocks argument to the removeImageForTag method in RCTImaeStoreManager.h and RCTImaeStoreManager.m node_modules/react-native/Libraries/Image.

The compiler appears to no longer treat empty arguments to a method as a warning. The fix is to make the empty argument void.

Original code:

- (void)removeImageForTag:(NSString *)imageTag withBlock:(void (^)())block

working code

- (void)removeImageForTag:(NSString *)imageTag withBlock:(void (^)(void))block

I don't know if this is a general fix, but it worked for me.

[tolgaduzenli]

doesnt work for me. RN 0.43.3
When I try @glebovitz 's solution I am getting this error;
Conflicting parameter types in implementation of 'removeImageForTag:withBlock:': 'void (^__strong)()' vs 'void (^__strong)(void)'

[glebovitz]

@tolgaduzenli - did you make the change to both the RCTImaeStoreManager.h and RCTImaeStoreManager.m files. Looks like you changed only the header file.

[tolgaduzenli]

@glebovitz thank you so much man, now my build is successful.

[shivankpal]

@glebovitz thankyou man

[goldblade]

@glebovitz thank you! i solved the problem

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

[delef]

We need a global solution to the problem

[andpor]

Same problem after upgrade to XCode 10.1

[cpojer]

Is there somebody who could send a Pull Request with a fix for this problem?

[github-actions]

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[shubhamguptadream11]

There hasn't been any activity on this issue from long. Also the reproducer provided doesn't seems to exist now.

If someone still getting this on latest RN version. Feel free to re-open this.