Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image doesn't support local animated webp #15543

Closed
hanxk opened this issue Aug 18, 2017 · 8 comments
Closed

Image doesn't support local animated webp #15543

hanxk opened this issue Aug 18, 2017 · 8 comments
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@hanxk
Copy link

hanxk commented Aug 18, 2017

Environment

  1. react-native -v: 0.47.1
  2. node -v: v8.3.0
  3. npm -v: 5.3.0

Build tools: Android Studio

React Code:

it not works:

<Image source={require('../../imgs/ezgif-1-cbfa2c9256.webp')}  style={{width: 120, height:120 }}/>

it works :
<Image source={{uri:'https://im.ezgif.com/tmp/ezgif-1-cbfa2c9256.webp'}} style={{width: 120, height:120 }}/>

Android:

compile 'com.facebook.fresco:animated-base-support:1.0.1'
compile 'com.facebook.fresco:animated-gif:1.0.1'
compile 'com.facebook.fresco:animated-webp:1.0.1'
compile 'com.facebook.fresco:webpsupport:1.0.1'
compile 'com.facebook.fresco:webpsupport:1.0.1'

Error Log:

TypeError: unsupported file type
at lookup (/code/workspace/dudu/node_modules/image-size/lib/index.js:35:9)
at /code/workspace/dudu/node_modules/image-size/lib/index.js:93:22
at /code/workspace/dudu/node_modules/image-size/lib/index.js:50:9
at /code/workspace/dudu/node_modules/graceful-fs/graceful-fs.js:43:10
at FSReqWrap.oncomplete (fs.js:135:15)

image

@hanxk hanxk changed the title Image doesn't support animated webp Image doesn't support local animated webp Aug 18, 2017
@ide
Copy link
Contributor

ide commented Aug 18, 2017

Looks like this library https://github.com/image-size/image-size might not support animated webp. That library needs to be updated first.

@MindFreeze
Copy link

If someone could at least update the docs, because the seem to be a lie now http://facebook.github.io/react-native/releases/0.47/docs/image.html#gif-and-webp-support-on-android

@StevenGBrown
Copy link

StevenGBrown commented Aug 27, 2017

This looks the same as #13102. I can reproduce the error with React Native 0.47, but it works with v0.48.0-rc.1 which has a newer version of image-size. #13102 (comment)

@pull-bot
Copy link

@facebook-github-bot no-template

1 similar comment
@pull-bot
Copy link

@facebook-github-bot no-template

@facebook-github-bot
Copy link
Contributor

Hey, thanks for reporting this issue! It looks like your description is missing some necessary information, or the list of reproduction steps is not complete. Can you please add all the details specified in the Issue Template? This is necessary for people to be able to understand and reproduce the issue being reported. I am going to close this, but feel free to open a new issue with the additional information provided. Thanks! See "What to Expect from Maintainers" to learn more.

@facebook-github-bot facebook-github-bot added the Ran Commands One of our bots successfully processed a command. label Oct 10, 2017
@facebook-github-bot
Copy link
Contributor

Hey, thanks for reporting this issue! It looks like your description is missing some necessary information, or the list of reproduction steps is not complete. Can you please add all the details specified in the Issue Template? This is necessary for people to be able to understand and reproduce the issue being reported. I am going to close this, but feel free to open a new issue with the additional information provided. Thanks! See "What to Expect from Maintainers" to learn more.

@facebook-github-bot facebook-github-bot added Needs more information Ran Commands One of our bots successfully processed a command. labels Oct 10, 2017
@StevenGBrown
Copy link

Issue has been fixed. See my last comment.

@facebook facebook locked as resolved and limited conversation to collaborators Oct 10, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Oct 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

7 participants