Skip to content

StyleSheet.flatten is returning frozen object. No need to be frozen, and not documented #15037

Closed
@Noitidart

Description

@Noitidart

Is this a bug report?

Yes. At the very least, if no one agrees that it "should not be frozen", then the docs need to be updated".

Have you read the Bugs section of the Contributing to React Native Guide?

Yes

Environment

  1. react-native -v: 0.46.3
  2. node -v: 7.8.0
  3. npm -v: 5.1.0
  4. yarn --version (if you use Yarn): n/a

Then, specify:

  • Target Platform: iOS
  • Development Operating System: macOS 10.12.5 (16F73)
  • Build tools: None. Just regular react-native run-ios.

Steps to Reproduce

(Write your steps here:)

  1. const styles = StyleSheet.create({ text:{ backgroundColor:'red' } });
  2. Now do const flatNew = StyleSheet.flatten(styles.text);
  3. Now Object.isFrozen(flatNew) is true. There is no need for this freeze. It should be mutable. If you really want it immutable, then docs need update. - http://facebook.github.io/react-native/releases/0.46/docs/stylesheet.html#flatten

Expected Behavior

There is no need for this freeze. It should be mutable. If you really want it immutable, then docs need update. - http://facebook.github.io/react-native/releases/0.46/docs/stylesheet.html#flatten

Actual Behavior

Object is frozen, it cannot be mutated.

Reproducible Demo

Link to expo reproducible: https://snack.expo.io/B1A17ZYrZ

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions