Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMD + D in iOS coupled with CMD + R in safari debugger causes critical exception: #125

Closed
jaygarcia opened this issue Mar 5, 2015 · 4 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@jaygarcia
Copy link
Contributor

Steps:

  • Launch app within Xcode
  • Focus iOS sim
  • hit CMD + D
  • Launch safari debugger within the JSContext
  • hit CMD + R in safari debugger
  • Focus on iOS sim
  • Watch your application crumble

Demo: http://www.screencast.com/t/NjysG3tf

2015-03-05_10-22-29

@jaygarcia
Copy link
Contributor Author

I will say that hitting CMD + D to allow a "detach" (or attach of the per the docs) of RCTLog is extremely helpful.

May I suggest that you guys add a log message to the console to instruct the developer to attach the debugger?

  [[RCTKeyCommands sharedInstance] registerKeyCommandWithInput:@"d"
                                                 modifierFlags:UIKeyModifierCommand
                                                        action:^(UIKeyCommand *command) {
                                                          _globalExecutorClass = [RCTWebViewExecutor class];
                                                          NSLog(@"Attach Safari Debugger at this time.");
                                                          [self reloadAll];
                                                        }];

@jaygarcia
Copy link
Contributor Author

Having this as a default configuration option for development would be great. Lots of web developers are not familiar with Xcode and when they do a console.log(), they may not know to look @ Xcode.

@sahrens
Copy link
Contributor

sahrens commented Mar 7, 2015

Don't worry, we have plenty of plans to make the integrated development and debugging experience awesome :)

-Spencer

On Mar 5, 2015, at 7:51 AM, Jay Garcia notifications@github.com wrote:

Having this as a default configuration option for development would be great. Lots of web developers are not familiar with Xcode and when they do a console.log(), they may not know to look @ Xcode.


Reply to this email directly or view it on GitHub.

@jaygarcia
Copy link
Contributor Author

^---

 ▄         ▄  ▄▄▄▄▄▄▄▄▄▄▄  ▄            ▄           
▐░▌       ▐░▌▐░░░░░░░░░░░▌▐░▌          ▐░▌          
▐░▌       ▐░▌▐░█▀▀▀▀▀▀▀▀▀ ▐░▌          ▐░▌          
▐░▌       ▐░▌▐░▌          ▐░▌          ▐░▌          
▐░█▄▄▄▄▄▄▄█░▌▐░█▄▄▄▄▄▄▄▄▄ ▐░▌          ▐░▌          
▐░░░░░░░░░░░▌▐░░░░░░░░░░░▌▐░▌          ▐░▌          
▐░█▀▀▀▀▀▀▀█░▌▐░█▀▀▀▀▀▀▀▀▀ ▐░▌          ▐░▌          
▐░▌       ▐░▌▐░▌          ▐░▌          ▐░▌          
▐░▌       ▐░▌▐░█▄▄▄▄▄▄▄▄▄ ▐░█▄▄▄▄▄▄▄▄▄ ▐░█▄▄▄▄▄▄▄▄▄ 
▐░▌       ▐░▌▐░░░░░░░░░░░▌▐░░░░░░░░░░░▌▐░░░░░░░░░░░▌
 ▀         ▀  ▀▀▀▀▀▀▀▀▀▀▀  ▀▀▀▀▀▀▀▀▀▀▀  ▀▀▀▀▀▀▀▀▀▀▀ 

 ▄         ▄  ▄▄▄▄▄▄▄▄▄▄▄  ▄▄▄▄▄▄▄▄▄▄▄  ▄  ▄        
▐░▌       ▐░▌▐░░░░░░░░░░░▌▐░░░░░░░░░░░▌▐░▌▐░▌       
▐░▌       ▐░▌▐░█▀▀▀▀▀▀▀▀▀ ▐░█▀▀▀▀▀▀▀▀▀ ▐░▌▐░▌       
▐░▌       ▐░▌▐░▌          ▐░▌          ▐░▌▐░▌       
▐░█▄▄▄▄▄▄▄█░▌▐░█▄▄▄▄▄▄▄▄▄ ▐░█▄▄▄▄▄▄▄▄▄ ▐░▌▐░▌       
▐░░░░░░░░░░░▌▐░░░░░░░░░░░▌▐░░░░░░░░░░░▌▐░▌▐░▌       
 ▀▀▀▀█░█▀▀▀▀ ▐░█▀▀▀▀▀▀▀▀▀  ▀▀▀▀▀▀▀▀▀█░▌▐░▌▐░▌       
     ▐░▌     ▐░▌                    ▐░▌ ▀  ▀        
     ▐░▌     ▐░█▄▄▄▄▄▄▄▄▄  ▄▄▄▄▄▄▄▄▄█░▌ ▄  ▄        
     ▐░▌     ▐░░░░░░░░░░░▌▐░░░░░░░░░░░▌▐░▌▐░▌       
      ▀       ▀▀▀▀▀▀▀▀▀▀▀  ▀▀▀▀▀▀▀▀▀▀▀  ▀  ▀        

harrykiselev pushed a commit to harrykiselev/react-native that referenced this issue Aug 5, 2015
@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants