Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After switching to the recommended header syntax for version .40 and greater, still cant find header files. #12178

Closed
the-simian opened this issue Feb 3, 2017 · 3 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@the-simian
Copy link

Description

We have a project currently at 0.39. Of course the first issue we had was not being able to find RCTBridgeModule.h

RCTBridgeModule.h' file not found

After carefully switching all the imports as per the upgrade guide:
https://github.com/facebook/react-native/wiki/Breaking-Changes#namespace-all-header-imports-to-react-e1577d---javache

In third-party native code, instead of
#import "RCTBridge.h"
use a name-spaced system import
#import <React/RCTBridge.h>

The project still throws the same errors.

If it matters this project does have podfiles.

Reproduction

We simply try to upgrade to 0.41 right now. It won't build. neither via updating the package.json, using react-native-upgrade-git nor react-native upgrade work. (Actually react-native-upgrade git made the xcode project so unstable it would not even open.)

The project is perfectly stable in v 0.39, and won't build in .40 and .41

Solution

I expect the project to build based on the migration guide.

Additional Information

  • React Native version: 0.39 to 0.41
  • Platform: IOS
  • Operating System: osx

possibly references : #11721

@the-simian
Copy link
Author

the-simian commented Feb 4, 2017

This got me much farther!

#11721 (comment)

Now I get (RCTConvert.h yoga/Yoga.h) file not found

references #11781

@the-simian
Copy link
Author

the-simian commented Feb 4, 2017

I was able to get that to go away by doing this, but I have duplicate declaration errors now, but they're related to AirMaps

screen shot 2017-02-03 at 9 05 47 pm

references react-native-maps/react-native-maps#937

@the-simian
Copy link
Author

I think my issue now is sufficiently different i will close this. seems to be in AirMaps

@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

2 participants