Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN 0.36] crash at RCTImageLoader dequeueTasks #10731

Closed
RichardJing opened this issue Nov 4, 2016 · 3 comments
Closed

[RN 0.36] crash at RCTImageLoader dequeueTasks #10731

RichardJing opened this issue Nov 4, 2016 · 3 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@RichardJing
Copy link

Description

Crash report contains only one line:

[RCTImageLoader dequeueTasks]_block_invoke (RCTImageLoader.m:254)

code at RCTImageLoader

 (void)dequeueTasks
{
  dispatch_async(_URLRequestQueue, ^{
    // Remove completed tasks
    for (RCTNetworkTask *task in self->_pendingTasks.reverseObjectEnumerator) {
      switch (task.status) {
        case RCTNetworkTaskFinished:
          [self->_pendingTasks removeObject:task];
          self->_activeTasks--;
          break;
        case RCTNetworkTaskPending:
          break;
        case RCTNetworkTaskInProgress:
          // Check task isn't "stuck"
          if (task.requestToken == nil) {
            RCTLogWarn(@"Task orphaned for request %@", task.request);
            [self->_pendingTasks removeObject:task];
            self->_activeTasks--;
            [task cancel];  //  **** Line 254 at here **** //
          }
          break;
      }
    }

Reproduction

Can not find a certain way to trigger this crash

Additional Information

  • React Native version: 0.36.0
  • Platform: iOS 10.0.1, iPhone 6s
@gitim
Copy link
Contributor

gitim commented Nov 4, 2016

It is the same bug as in #10433

@brentvatne
Copy link
Collaborator

Indeed, dupe of #10433

@huitsing
Copy link
Contributor

huitsing commented Dec 2, 2016

#10433 was closed with a fix that addresses some image loading crashes, but not this crash, AFAIK. Should it be re-opened, or should this issue be re-opened?

@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants