Skip to content

Commit ff984ac

Browse files
NickGerlemanfacebook-github-bot
authored andcommitted
Move flex gap props to correct type
Summary: Missed while reviewing #34974 that flex gap props in Flow typings were added to ShadowStyle instead of LayoutStyle (directly above). The same issue is not present in the TS typings. Changelog: [General][Fixed] - Move flex gap props to the correct type Reviewed By: yungsters Differential Revision: D41736652 fbshipit-source-id: de0db1676464fbd962b2c7e7e9ef62b795332f1b
1 parent 92a705b commit ff984ac

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

Libraries/StyleSheet/StyleSheetTypes.js

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -554,6 +554,19 @@ type ____LayoutStyle_Internal = $ReadOnly<{
554554
* @platform ios
555555
*/
556556
direction?: 'inherit' | 'ltr' | 'rtl',
557+
558+
/**
559+
* In React Native, gap works the same way it does in CSS.
560+
* If there are two or more children in a container, they will be separated from each other
561+
* by the value of the gap - but the children will not be separated from the edges of their parent container.
562+
* For horizontal gaps, use columnGap, for vertical gaps, use rowGap, and to apply both at the same time, it's gap.
563+
* When align-content or justify-content are set to space-between or space-around, the separation
564+
* between children may be larger than the gap value.
565+
* See https://developer.mozilla.org/en-US/docs/Web/CSS/gap for more details.
566+
*/
567+
rowGap?: number,
568+
columnGap?: number,
569+
gap?: number,
557570
}>;
558571

559572
/**
@@ -590,19 +603,6 @@ export type ____ShadowStyle_InternalCore = $ReadOnly<{
590603
* @platform ios
591604
*/
592605
shadowRadius?: number,
593-
594-
/**
595-
* In React Native, gap works the same way it does in CSS.
596-
* If there are two or more children in a container, they will be separated from each other
597-
* by the value of the gap - but the children will not be separated from the edges of their parent container.
598-
* For horizontal gaps, use columnGap, for vertical gaps, use rowGap, and to apply both at the same time, it's gap.
599-
* When align-content or justify-content are set to space-between or space-around, the separation
600-
* between children may be larger than the gap value.
601-
* See https://developer.mozilla.org/en-US/docs/Web/CSS/gap for more details.
602-
*/
603-
rowGap?: number,
604-
columnGap?: number,
605-
gap?: number,
606606
}>;
607607

608608
export type ____ShadowStyle_Internal = $ReadOnly<{

0 commit comments

Comments
 (0)