From fdbe4719e2e2b599e86d42c49d42c4da97ef431a Mon Sep 17 00:00:00 2001
From: Riccardo Cipolleschi <cipolleschi@fb.com>
Date: Thu, 28 Apr 2022 08:53:24 -0700
Subject: [PATCH] fix: Make WebSocketTests work in CI (#33721)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Summary:
This PR reestablish the WebSocketTest in CI which is making the `test_ios_unit` fail.

**Note:** the test_ios_unit is actually running integration tests...

## Changelog

[iOS] [Changed] - Fix the test_ios_unit test

Pull Request resolved: https://github.com/facebook/react-native/pull/33721

Test Plan: The CI of this PR is green. 😬

Reviewed By: cortinico

Differential Revision: D36002823

Pulled By: cipolleschi

fbshipit-source-id: 20eeb08bfd02658ad6579085241f81654f74c1af
---
 .circleci/config.yml                          |  8 +++---
 ...erver.command => launchWebSocketServer.sh} | 12 +++------
 scripts/objc-test.sh                          | 26 ++++++++++++++++---
 3 files changed, 30 insertions(+), 16 deletions(-)
 rename IntegrationTests/{launchWebSocketServer.command => launchWebSocketServer.sh} (67%)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 8f1dc1809bb365..1ba961dfdab417 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -432,7 +432,7 @@ jobs:
   # -------------------------
   #     JOBS: iOS Unit Tests
   # -------------------------
-  test_ios_unit:
+  test_ios:
     executor: reactnativeios
     parameters:
       use_frameworks:
@@ -1237,7 +1237,7 @@ workflows:
             - build_npm_package
       - test_ios_rntester
       - build_ios
-      - test_ios_unit:
+      - test_ios:
           run_unit_tests: true
           requires:
             - build_ios
@@ -1245,8 +1245,8 @@ workflows:
       # - build_ios:
       #     name: build_ios_frameworks
       #     use_frameworks: true
-      # - test_ios_unit:
-      #     name: test_ios_unit_frameworks
+      # - test_ios:
+      #     name: test_ios_frameworks
       #     use_frameworks: true
       #     run_unit_tests: true
       #     requires:
diff --git a/IntegrationTests/launchWebSocketServer.command b/IntegrationTests/launchWebSocketServer.sh
similarity index 67%
rename from IntegrationTests/launchWebSocketServer.command
rename to IntegrationTests/launchWebSocketServer.sh
index 31bb3496df3341..cc736a5ceffd42 100755
--- a/IntegrationTests/launchWebSocketServer.command
+++ b/IntegrationTests/launchWebSocketServer.sh
@@ -1,18 +1,12 @@
 #!/bin/bash
-
 # Copyright (c) Meta Platforms, Inc. and affiliates.
 #
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
-# Set terminal title
-echo -en "\033]0;Web Socket Test Server\a"
-clear
-
 THIS_DIR=$(cd -P "$(dirname "$(readlink "${BASH_SOURCE[0]}" || echo "${BASH_SOURCE[0]}")")" && pwd)
-pushd "$THIS_DIR"
+pushd "$THIS_DIR" || exit
 ./websocket_integration_test_server.js
-popd
+popd || exit
 
-echo "Process terminated. Press <enter> to close the window"
-read
+echo "Process terminated."
diff --git a/scripts/objc-test.sh b/scripts/objc-test.sh
index d2d6ecaa0075cc..a787bab5989045 100755
--- a/scripts/objc-test.sh
+++ b/scripts/objc-test.sh
@@ -55,6 +55,24 @@ waitForPackager() {
   echo "Packager is ready!"
 }
 
+waitForWebSocketServer() {
+  local -i max_attempts=60
+  local -i attempt_num=1
+
+  until curl -s http://localhost:5555 | grep "Upgrade Required" -q; do
+    if (( attempt_num == max_attempts )); then
+      echo "WebSocket Server did not respond in time. No more attempts left."
+      exit 1
+    else
+      (( attempt_num++ ))
+      echo "WebSocket Server did not respond. Retrying for attempt number $attempt_num..."
+      sleep 1
+    fi
+  done
+
+  echo "WebSocket Server is ready!"
+}
+
 runTests() {
   # shellcheck disable=SC1091
   source "./scripts/.tests.env"
@@ -102,11 +120,13 @@ main() {
   # Otherwise, just build RNTester and exit
   if [ "$1" = "test" ]; then
 
-    # Start the packager
-    yarn start --max-workers=1 || echo "Can't start packager automatically" &
     # Start the WebSocket test server
-    open "./IntegrationTests/launchWebSocketServer.command" || echo "Can't start web socket server automatically"
+    echo "Launch WebSocket Server"
+    sh "./IntegrationTests/launchWebSocketServer.sh" &
+    waitForWebSocketServer
 
+    # Start the packager
+    yarn start --max-workers=1 || echo "Can't start packager automatically" &
     waitForPackager
     preloadBundles