-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Replace RAIICallbackWrapperDestroyer with AsyncCallback (re-land) (#4…
…1048) Summary: Pull Request resolved: #41048 Reapplies D49792717 AsyncCallback and SyncCallbacks are better primitives for jsi::Function handling. The code is simpler and requires less manual argument passing. See in D49684248 how the API was extended to support more use-cases. The underlying issue causing memory corruption has been addressed in D50286876. Changelog: [Deprecated] AsyncCallback replaces RAIICallbackWrapperDestroyer as a safer way to manage jsi::Function memory ownership. Reviewed By: rshest Differential Revision: D50319914 fbshipit-source-id: e038813cad85c47be1f004bc2ea1fdaf0eee9094
- Loading branch information
1 parent
4134d8d
commit fbd8504
Showing
2 changed files
with
101 additions
and
150 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters