Skip to content

Commit

Permalink
Revert D21064653: Remove the post install step
Browse files Browse the repository at this point in the history
Differential Revision:
D21064653

Original commit changeset: da56d0754d91

fbshipit-source-id: 1086cfdeca9aa3830370ea115ba7b5f05d3fb124
  • Loading branch information
elicwhite authored and facebook-github-bot committed Apr 16, 2020
1 parent 44beb2a commit fb04237
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
11 changes: 11 additions & 0 deletions scripts/react_native_pods.rb
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,14 @@ def use_flipper!(versions = {})
pod 'FlipperKit/FlipperKitLayoutTextSearchable', versions['Flipper'], :configuration => 'Debug'
pod 'FlipperKit/FlipperKitNetworkPlugin', versions['Flipper'], :configuration => 'Debug'
end

# Post Install processing for Flipper
def flipper_post_install(installer)
installer.pods_project.targets.each do |target|
if target.name == 'YogaKit'
target.build_configurations.each do |config|
config.build_settings['SWIFT_VERSION'] = '4.1'
end
end
end
end
3 changes: 3 additions & 0 deletions template/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ target 'HelloWorld' do
# Note that if you have use_frameworks! enabled, Flipper will not work and
# you should disable these next few lines.
use_flipper!
post_install do |installer|
flipper_post_install(installer)
end
end

target 'HelloWorld-tvOS' do
Expand Down

1 comment on commit fb04237

@alloy
Copy link
Contributor

@alloy alloy commented on fb04237 May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this reverted?

Please sign in to comment.