Skip to content

Commit

Permalink
chore: fix grammar in Xcode 15 helper method name (#39658)
Browse files Browse the repository at this point in the history
Summary:
Thanks for working through Xcode 15 compatibility issues!

I reviewed the diff of the PR (#39474) that altered Xcode 15 settings for react-native release 0.72.5 and I noticed that

- everything looked great (worth saying)
- there was a grammatical error in another of the method names

Trivial errors but, as long as I was in there, thought I'd submit a PR

## Changelog:

[IOS] [FIXED] - fix grammar in Xcode 15 helper method name

Pull Request resolved: #39658

Test Plan: CI should catch it of course, but in general I did a full grep for the name and changed everything / typical method name refactor

Reviewed By: cortinico

Differential Revision: D49641551

Pulled By: cipolleschi

fbshipit-source-id: d77d33bbd6941f039dd30766e1308d5c4c4a6ca8
  • Loading branch information
mikehardy authored and facebook-github-bot committed Sep 27, 2023
1 parent 6eb4f1e commit fa87eaa
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/react-native/scripts/cocoapods/utils.rb
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ def self.apply_xcode_15_patch(installer, xcodebuild_manager: Xcodebuild)
if self.is_using_xcode15_or_greater(:xcodebuild_manager => xcodebuild_manager)
self.add_value_to_setting_if_missing(config, other_ld_flags_key, xcode15_compatibility_flags)
else
self.remove_value_to_setting_if_present(config, other_ld_flags_key, xcode15_compatibility_flags)
self.remove_value_from_setting_if_present(config, other_ld_flags_key, xcode15_compatibility_flags)
end
end
project.save()
Expand Down Expand Up @@ -346,7 +346,7 @@ def self.add_value_to_setting_if_missing(config, setting_name, value)
end
end

def self.remove_value_to_setting_if_present(config, setting_name, value)
def self.remove_value_from_setting_if_present(config, setting_name, value)
old_config = config.build_settings[setting_name]
if old_config.include?(value)
# Old config can be either an Array or a String
Expand Down

0 comments on commit fa87eaa

Please sign in to comment.