move getEventArgument fn to parsers-commons.js

Revert "move `getEventArgument` fn to `parsers-commons.js`"

This reverts commit ce660bd.

Address feedback

use EventTypeAnnotation instead of defining type

Author: siddarthkay

packages/react-native-codegen/src/parsers/flow/components/events.js

@@ -20,6 +20,7 @@ const {
   throwIfEventHasNoName,
   throwIfBubblingTypeIsNull,
 } = require('../../error-utils');
+const {getEventArgument} = require('../../parsers-commons');
 
 function getPropertyType(
   /* $FlowFixMe[missing-local-annot] The type annotation(s) required by Flow's
@@ -185,15 +186,6 @@ function buildPropertiesForEvent(property): NamedShape<EventTypeAnnotation> {
   return getPropertyType(name, optional, typeAnnotation);
 }
 
-/* $FlowFixMe[missing-local-annot] The type annotation(s) required by Flow's
- * LTI update could not be added via codemod */
-function getEventArgument(argumentProps, name: $FlowFixMe) {
-  return {
-    type: 'ObjectTypeAnnotation',
-    properties: argumentProps.map(buildPropertiesForEvent),
-  };
-}
-
 function buildEventSchema(
   types: TypeMap,
   property: EventTypeAST,
@@ -228,7 +220,7 @@ function buildEventSchema(
         paperTopLevelNameDeprecated,
         typeAnnotation: {
           type: 'EventTypeAnnotation',
-          argument: getEventArgument(argumentProps, name),
+          argument: getEventArgument(argumentProps, buildPropertiesForEvent),
         },
       };
     }
@@ -239,7 +231,7 @@ function buildEventSchema(
       bubblingType,
       typeAnnotation: {
         type: 'EventTypeAnnotation',
-        argument: getEventArgument(argumentProps, name),
+        argument: getEventArgument(argumentProps, buildPropertiesForEvent),
       },
     };
   }

packages/react-native-codegen/src/parsers/parsers-commons.js

@@ -23,6 +23,8 @@ import type {
   SchemaType,
   NativeModuleEnumMap,
   OptionsShape,
+  EventTypeAnnotation,
+  ObjectTypeAnnotation,
 } from '../CodegenSchema.js';
 
 import type {Parser} from './parser';
@@ -852,6 +854,20 @@ function extendsForProp(
   }
 }
 
+/* $FlowFixMe[missing-local-annot] The type annotation(s) required by Flow's
+ * LTI update could not be added via codemod */
+function getEventArgument(
+  argumentProps: PropAST,
+  buildPropertiesForEvent: (
+    property: PropAST,
+  ) => NamedShape<EventTypeAnnotation>,
+): ObjectTypeAnnotation<EventTypeAnnotation> {
+  return {
+    type: 'ObjectTypeAnnotation',
+    properties: argumentProps.map(buildPropertiesForEvent),
+  };
+}
+
 module.exports = {
   wrapModuleSchema,
   unwrapNullable,
@@ -872,4 +888,5 @@ module.exports = {
   getOptions,
   getCommandTypeNameAndOptionsExpression,
   extendsForProp,
+  getEventArgument,
 };

packages/react-native-codegen/src/parsers/typescript/components/events.js

@@ -23,7 +23,7 @@ const {
   throwIfEventHasNoName,
   throwIfBubblingTypeIsNull,
 } = require('../../error-utils');
-
+const {getEventArgument} = require('../../parsers-commons');
 function getPropertyType(
   /* $FlowFixMe[missing-local-annot] The type annotation(s) required by Flow's
    * LTI update could not be added via codemod */
@@ -206,15 +206,6 @@ function buildPropertiesForEvent(property): NamedShape<EventTypeAnnotation> {
   return getPropertyType(name, optional, typeAnnotation);
 }
 
-/* $FlowFixMe[missing-local-annot] The type annotation(s) required by Flow's
- * LTI update could not be added via codemod */
-function getEventArgument(argumentProps, name: $FlowFixMe) {
-  return {
-    type: 'ObjectTypeAnnotation',
-    properties: argumentProps.map(buildPropertiesForEvent),
-  };
-}
-
 // $FlowFixMe[unclear-type] TODO(T108222691): Use flow-types for @babel/parser
 type EventTypeAST = Object;
 
@@ -248,7 +239,7 @@ function buildEventSchema(
         paperTopLevelNameDeprecated,
         typeAnnotation: {
           type: 'EventTypeAnnotation',
-          argument: getEventArgument(argumentProps, name),
+          argument: getEventArgument(argumentProps, buildPropertiesForEvent),
         },
       };
     }
@@ -259,7 +250,7 @@ function buildEventSchema(
       bubblingType,
       typeAnnotation: {
         type: 'EventTypeAnnotation',
-        argument: getEventArgument(argumentProps, name),
+        argument: getEventArgument(argumentProps, buildPropertiesForEvent),
       },
     };
   }