From f6b9a429853aa5fcb7895a144c77b538e9017c1e Mon Sep 17 00:00:00 2001 From: Soe Lynn Date: Tue, 9 Apr 2024 17:47:25 -0700 Subject: [PATCH] Deprecate react_native_image_logging GK (#44009) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/44009 Pull Request resolved: https://github.com/facebook/react-native/pull/43997 Pull Request resolved: https://github.com/facebook/react-native/pull/43879 Clean up RCTImageLoadingPerfInstrumentationEnabled as GK is 100% Changelog: [iOS][Breaking] Remove unused RCTImageLoadingPerfInstrumentationEnabled Reviewed By: philIip Differential Revision: D55769009 fbshipit-source-id: c99a7b7076597e65acc0ba97f5a4846719688401 --- .../react-native/Libraries/Image/RCTImageLoader.mm | 12 ------------ .../Image/RCTImageLoaderWithAttributionProtocol.h | 3 --- 2 files changed, 15 deletions(-) diff --git a/packages/react-native/Libraries/Image/RCTImageLoader.mm b/packages/react-native/Libraries/Image/RCTImageLoader.mm index 2f1db93ce3d4e1..46b267ccccaa42 100644 --- a/packages/react-native/Libraries/Image/RCTImageLoader.mm +++ b/packages/react-native/Libraries/Image/RCTImageLoader.mm @@ -26,18 +26,6 @@ using namespace facebook::react; -static BOOL imagePerfInstrumentationEnabled = NO; - -BOOL RCTImageLoadingPerfInstrumentationEnabled(void) -{ - return imagePerfInstrumentationEnabled; -} - -void RCTEnableImageLoadingPerfInstrumentation(BOOL enabled) -{ - imagePerfInstrumentationEnabled = enabled; -} - static NSInteger RCTImageBytesForImage(UIImage *image) { NSInteger singleImageBytes = (NSInteger)(image.size.width * image.size.height * image.scale * image.scale * 4); diff --git a/packages/react-native/Libraries/Image/RCTImageLoaderWithAttributionProtocol.h b/packages/react-native/Libraries/Image/RCTImageLoaderWithAttributionProtocol.h index 14997865e50dae..a70610c60219f5 100644 --- a/packages/react-native/Libraries/Image/RCTImageLoaderWithAttributionProtocol.h +++ b/packages/react-native/Libraries/Image/RCTImageLoaderWithAttributionProtocol.h @@ -10,9 +10,6 @@ #import #import -RCT_EXTERN BOOL RCTImageLoadingPerfInstrumentationEnabled(void); -RCT_EXTERN void RCTEnableImageLoadingPerfInstrumentation(BOOL enabled); - @protocol RCTImageLoaderWithAttributionProtocol // TODO (T61325135): Remove C++ checks