Skip to content

Commit

Permalink
Use NDK 23 only for Windows users. (#33611)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #33611

Bumping the NDK to 23 to prevent build failures due to the NDK
using longer paths.

Changelog:
[Android] [Fixed] - Use NDK 23 only for Windows users.

Reviewed By: motiz88

Differential Revision: D35547459

fbshipit-source-id: 4e44c0b5fd8d1c559b04fb43eb4eeadc13943394
  • Loading branch information
cortinico authored and facebook-github-bot committed Apr 13, 2022
1 parent 86f8d0b commit e48a580
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions template/android/build.gradle
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import org.apache.tools.ant.taskdefs.condition.Os

// Top-level build file where you can add configuration options common to all sub-projects/modules.

buildscript {
Expand All @@ -6,11 +8,16 @@ buildscript {
minSdkVersion = 21
compileSdkVersion = 31
targetSdkVersion = 31
// For M1 Users we need to use the NDK 24, otherwise we default to the
// side-by-side NDK version from AGP.

if (System.properties['os.arch'] == "aarch64") {
// For M1 Users we need to use the NDK 24 which added support for aarch64
ndkVersion = "24.0.8215888"
} else if (Os.isFamily(Os.FAMILY_WINDOWS)) {
// For Android Users, we need to use NDK 23, otherwise the build will
// fail due to paths longer than the OS limit
ndkVersion = "23.1.7779620"
} else {
// Otherwise we default to the side-by-side NDK version from AGP.
ndkVersion = "21.4.7075529"
}
}
Expand Down

0 comments on commit e48a580

Please sign in to comment.