From e42009b7849f1cfd6d6d34e28c564ec5e39680bb Mon Sep 17 00:00:00 2001 From: David Vacca Date: Wed, 24 Jul 2019 22:26:46 -0700 Subject: [PATCH] Deprecate UIManager.measureLayoutRelativeToParent Summary: UIManager.measureLayoutRelativeToParent will not be supported as part of fabric. This diff deprecates this method in the current version or React Native. Reviewed By: fkgozali Differential Revision: D16471845 fbshipit-source-id: acfda9bfb2dd8553ff8e359ea2c8d7d88a14c6d2 --- React/Modules/RCTUIManager.m | 1 + .../java/com/facebook/react/uimanager/UIManagerModule.java | 3 +++ 2 files changed, 4 insertions(+) diff --git a/React/Modules/RCTUIManager.m b/React/Modules/RCTUIManager.m index 840b4501805465..7e3a67b485cb0e 100644 --- a/React/Modules/RCTUIManager.m +++ b/React/Modules/RCTUIManager.m @@ -1398,6 +1398,7 @@ static void RCTMeasureLayout(RCTShadowView *view, errorCallback:(__unused RCTResponseSenderBlock)errorCallback callback:(RCTResponseSenderBlock)callback) { + RCTLogWarn(@"RCTUIManager.measureLayoutRelativeToParent method is deprecated and it will not be implemented in newer versions of RN (Fabric) - T47686450"); RCTShadowView *shadowView = _shadowViewRegistry[reactTag]; RCTMeasureLayout(shadowView, shadowView.reactSuperview, callback); } diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java index 3b703e34640704..1f35d92cfbbca1 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java +++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java @@ -607,8 +607,11 @@ public void measureLayout( *

NB: Unlike {@link #measure}, this will measure relative to the view layout, not the visible * window which can cause unexpected results when measuring relative to things like ScrollViews * that can have offset content on the screen. + * + * @deprecated This method will not be part of Fabric. */ @ReactMethod + @Deprecated public void measureLayoutRelativeToParent( int tag, Callback errorCallback, Callback successCallback) { mUIImplementation.measureLayoutRelativeToParent(tag, errorCallback, successCallback);