Skip to content

Commit

Permalink
refine android config (#20731)
Browse files Browse the repository at this point in the history
Summary:
By this change we can unify version early, like we can make kotlin version share in buildscript and app dependency the same time ([butterknife](https://github.com/JakeWharton/butterknife/blob/master/build.gradle) use the same).
pass all current ci and one of my project https://github.com/gengjiawen/ReactNative64bitDemo.
none
 [GENERAL] [ANDROID] [TEMPLATE] - refine android config
Pull Request resolved: #20731

Differential Revision: D9482954

Pulled By: hramos

fbshipit-source-id: d864adbdbc624bc311ccc5f44a15d0334d2d8a59
  • Loading branch information
gengjiawen authored and facebook-github-bot committed Aug 23, 2018
1 parent 3949e93 commit e2f2e41
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions local-cli/templates/HelloWorld/android/build.gradle
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.

buildscript {
ext {
buildToolsVersion = "27.0.3"
minSdkVersion = 16
compileSdkVersion = 27
targetSdkVersion = 26
supportLibVersion = "27.1.1"
}
repositories {
jcenter()
google()
Expand All @@ -25,13 +32,6 @@ allprojects {
}
}

ext {
buildToolsVersion = "27.0.3"
minSdkVersion = 16
compileSdkVersion = 27
targetSdkVersion = 26
supportLibVersion = "27.1.1"
}

task wrapper(type: Wrapper) {
gradleVersion = '4.4'
Expand Down

0 comments on commit e2f2e41

Please sign in to comment.