Skip to content

Commit

Permalink
Restore Dynamic framework with JSC in the Old Architecture
Browse files Browse the repository at this point in the history
Summary:
I discovered that 0.69 and 0.70 could run React Native as Dynamic framework with JSC and starting from 0.71 that's not possible anymore.
This diff restore that possibility.

## Changelog
[iOS][Fixed] - Add Back dynamic framework support for the old architecture

Reviewed By: cortinico

Differential Revision: D42829137

fbshipit-source-id: 848672f714d8bab133e42f5e3b80202b350d5261
  • Loading branch information
cipolleschi authored and facebook-github-bot committed Jan 30, 2023
1 parent dc959c9 commit da270d0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
4 changes: 4 additions & 0 deletions React-Core.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -114,4 +114,8 @@ Pod::Spec.new do |s|
s.dependency "React-jsiexecutor", version
s.dependency "Yoga"
s.dependency "glog"

if ENV['USE_HERMES'] == "0"
s.dependency 'React-jsc'
end
end
1 change: 1 addition & 0 deletions React/CoreModules/React-CoreModules.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,5 @@ Pod::Spec.new do |s|
s.dependency "React-RCTImage", version
s.dependency "ReactCommon/turbomodule/core", version
s.dependency "React-jsi", version
s.dependency 'React-RCTBlob'
end

0 comments on commit da270d0

Please sign in to comment.