Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added missing constructor to WritableNativeArray (#32796)
Summary: `WritableNativeMap` has two constructors: ```c++ WritableNativeMap(); WritableNativeMap(folly::dynamic &&val); ``` but `WritableNativeMap` has only one constructor: ```c++ WritableNativeMap(); ``` Without a second constructor, I am not able to create `WritableNativeMap` from the existing array. I added this second constructor because I need it for `react-native-reanimated`. ## Changelog [Android] [Added] - Added missing constructor to WritableNativeArray Pull Request resolved: #32796 Test Plan: ```c++ std::shared_ptr<jsi::Runtime> rt = facebook::hermes::makeHermesRuntime(); jsi::Value value; WritableNativeMap::newObjectCxxArgs(jsi::dynamicFromValue(*rt.get(), value)); ``` Reviewed By: cortinico Differential Revision: D33285316 Pulled By: lunaleaps fbshipit-source-id: 1bbd816892f34ae6fef747066893fe3b803c088d
- Loading branch information