decouple RCTHost bundleURL setter from delegate (#37566)

Summary:
Pull Request resolved: #37566

Changelog: [Internal]

in this diff stack, i remove `- (NSURL *)getBundleURL;` from the bridgeless API.

the reason for this is because the bundle url does not change in the middle of an app session, unless for developer mode, so it's more robust for us to pass it as a dependency.

at the end of the diff stack, i'll add an escape hatch that allows us to update the bundle url for our dev mode case, so we can delete the API.

in this diff, i do some cleanup so the bundle logic is more reusable.

Reviewed By: sammy-SC

Differential Revision: D45937853

fbshipit-source-id: e80bacfa7342f63caa020e4a00750ffa156bf8e7

Author: philIip

packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTHost.mm

@@ -79,11 +79,7 @@ - (instancetype)initWithHostDelegate:(id<RCTHostDelegate>)hostDelegate
     };
 
     auto bundleURLSetter = ^(NSURL *bundleURL) {
-      RCTHost *strongSelf = weakSelf;
-      if (!strongSelf) {
-        return;
-      }
-      strongSelf->_bundleURL = bundleURL;
+      [weakSelf _setBundleURL:bundleURL];
     };
 
     auto defaultBundleURLGetter = ^NSURL *()
@@ -144,8 +140,7 @@ - (void)start
         @"RCTHost should not be creating a new instance if one already exists. This implies there is a bug with how/when this method is being called.");
     [_instance invalidate];
   }
-  [self _refreshBundleURL];
-  RCTReloadCommandSetBundleURL(_bundleURL);
+  [self _setBundleURL:[_hostDelegate getBundleURL]];
   _instance = [[RCTInstance alloc] initWithDelegate:self
                                    jsEngineInstance:[self _provideJSEngine]
                                       bundleManager:_bundleManager
@@ -204,8 +199,7 @@ - (void)didReceiveReloadCommand
 {
   [_instance invalidate];
   _instance = nil;
-  [self _refreshBundleURL];
-  RCTReloadCommandSetBundleURL(_bundleURL);
+  [self _setBundleURL:[_hostDelegate getBundleURL]];
 
   // Ensure all attached surfaces are restarted after reload
   {
@@ -272,19 +266,6 @@ - (void)registerSegmentWithId:(NSNumber *)segmentId path:(NSString *)path
 
 #pragma mark - Private
 
-- (void)_refreshBundleURL FB_OBJC_DIRECT
-{
-  // Reset the _bundleURL ivar if the RCTHost delegate presents a new bundleURL
-  NSURL *newDelegateBundleURL = [_hostDelegate getBundleURL];
-  if (newDelegateBundleURL && ![newDelegateBundleURL isEqual:_oldDelegateBundleURL]) {
-    _oldDelegateBundleURL = newDelegateBundleURL;
-    _bundleURL = newDelegateBundleURL;
-  }
-
-  // Sanitize the bundle URL
-  _bundleURL = [RCTConvert NSURL:_bundleURL.absoluteString];
-}
-
 - (void)_attachSurface:(RCTFabricSurface *)surface FB_OBJC_DIRECT
 {
   _attachedSurfaces.push_back(surface);
@@ -311,4 +292,20 @@ - (void)_attachSurface:(RCTFabricSurface *)surface FB_OBJC_DIRECT
   return jsEngine;
 }
 
+- (void)_setBundleURL:(NSURL *)bundleURL
+{
+  // Reset the _bundleURL ivar if the RCTHost delegate presents a new bundleURL
+  NSURL *newDelegateBundleURL = bundleURL;
+  if (newDelegateBundleURL && ![newDelegateBundleURL isEqual:_oldDelegateBundleURL]) {
+    _oldDelegateBundleURL = newDelegateBundleURL;
+    _bundleURL = newDelegateBundleURL;
+  }
+
+  // Sanitize the bundle URL
+  _bundleURL = [RCTConvert NSURL:_bundleURL.absoluteString];
+
+  // Update the global bundle URLq
+  RCTReloadCommandSetBundleURL(_bundleURL);
+}
+
 @end