Skip to content

Commit

Permalink
Adding missing #import <QuartzCore/QuartzCore.h> imports (#35315)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #35315

These headers are needed on react-native-macOS, but not explicitly imported all the time.

It seems that some UIKit header will implicitly import them.

We have other use case in react-native(-iOS) in which we also explicitly importing them - https://github.com/facebook/react-native/search?q=QuartzCore- , hence use following 'that' practice 'here'.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D41229835

fbshipit-source-id: b0182bf4f7905e8e157b341eb62cadec6ba354ca
  • Loading branch information
christophpurrer authored and facebook-github-bot committed Nov 14, 2022
1 parent 3921f05 commit c0f06e8
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Libraries/Text/Text/RCTTextView.m
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

#import <React/RCTTextShadowView.h>

#import <QuartzCore/QuartzCore.h>

@implementation RCTTextView {
CAShapeLayer *_highlightLayer;
UILongPressGestureRecognizer *_longPressGestureRecognizer;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#import "RCTViewComponentView.h"

#import <CoreGraphics/CoreGraphics.h>
#import <QuartzCore/QuartzCore.h>
#import <objc/runtime.h>

#import <React/RCTAssert.h>
Expand Down
1 change: 1 addition & 0 deletions React/Fabric/Mounting/RCTMountingManager.mm
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

#import "RCTMountingManager.h"

#import <QuartzCore/QuartzCore.h>
#import <butter/map.h>

#import <React/RCTAssert.h>
Expand Down
1 change: 1 addition & 0 deletions React/Views/RCTView.m
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

#import "RCTView.h"

#import <QuartzCore/QuartzCore.h>
#import <React/RCTMockDef.h>

#import "RCTAutoInsetsProtocol.h"
Expand Down

0 comments on commit c0f06e8

Please sign in to comment.