[Fix] Let React Native decide the Hermes version to use in the Codegen

facebook · Nov 3, 2022 · becb47c · becb47c
1 parent f0054e1
commit becb47c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/scripts/cocoapods/__tests__/codegen_utils-test.rb b/scripts/cocoapods/__tests__/codegen_utils-test.rb
@@ -465,7 +465,7 @@ def get_podspec_no_fabric_no_script
             "RCTTypeSafety": ["99.98.97"],
             "React-Core": ["99.98.97"],
             "React-jsi": ["99.98.97"],
-            "hermes-engine": ["99.98.97"],
+            "hermes-engine": [],
             "ReactCommon/turbomodule/core": ["99.98.97"]
           }
         }

diff --git a/scripts/cocoapods/codegen_utils.rb b/scripts/cocoapods/codegen_utils.rb
@@ -118,7 +118,7 @@ def get_react_codegen_spec(package_json_file, folly_version: '2021.07.22.00', fa
 
         if hermes_enabled
           spec[:'dependencies'].merge!({
-            'hermes-engine': [version],
+            'hermes-engine': [], # let React Native decide which version of Hermes Engine to be used. Otherwise, this can create conflicts.
           });
         else
           spec[:'dependencies'].merge!({