Skip to content

Commit

Permalink
Properly support both libraries and use_frameworks (#35624) (#35637)
Browse files Browse the repository at this point in the history
Summary:
Backporting a [fix](c6fa633) on the `ReactCommon.podspec` to properly support static libraries and
static frameworks
## Changelog

[IOS][FIXED] - Properly support static libraries and static frameworks

Pull Request resolved: #35637

Test Plan: Tested in 0.71-RC4

Reviewed By: christophpurrer

Differential Revision: D42029571

Pulled By: cipolleschi

fbshipit-source-id: e562fe211931a0aebba282057589e5dd4fafe3ba
  • Loading branch information
Riccardo authored and facebook-github-bot committed Dec 14, 2022
1 parent 83afdaf commit be895c8
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion ReactCommon/ReactCommon.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ Pod::Spec.new do |s|
ss.subspec "core" do |sss|
sss.source_files = "react/nativemodule/core/ReactCommon/**/*.{cpp,h}",
"react/nativemodule/core/platform/ios/**/*.{mm,cpp,h}"
sss.exclude_files = "react/nativemodule/core/ReactCommon/{LongLivedObject,CallbackWrapper}.h"
excluded_files = ENV['USE_FRAMEWORKS'] == nil ?
"react/nativemodule/core/ReactCommon/LongLivedObject.h" :
"react/nativemodule/core/ReactCommon/{LongLivedObject,CallbackWrapper}.h"
sss.exclude_files = excluded_files
end

ss.subspec "samples" do |sss|
Expand Down

0 comments on commit be895c8

Please sign in to comment.