Skip to content

Commit bc16bc5

Browse files
Add number | null to ViewProps['hitSlop'] TypeScript type (#41070)
Summary: Setting the `hitSlop` of a `View` to be a `number` didn't work. The Flow type already allows `number`: https://github.com/facebook/react-native/blob/6e42c98aa3423cfbc389e4fe877b5c6b559c8a81/packages/react-native/Libraries/Components/View/ViewPropTypes.js#L618 I updated it to match the [`TouchableWithoutFeedbackProps['hitSlop']`](https://github.com/facebook/react-native/blob/6e42c98aa3423cfbc389e4fe877b5c6b559c8a81/packages/react-native/Libraries/Components/Touchable/TouchableWithoutFeedback.d.ts#L72) and [`PressableProps['hitSlop']`](https://github.com/facebook/react-native/blob/6e42c98aa3423cfbc389e4fe877b5c6b559c8a81/packages/react-native/Libraries/Components/Pressable/Pressable.d.ts#L126) types. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [GENERAL] [FIXED] Add `number | null` to `ViewProps['hitSlop']` TypeScript type Pull Request resolved: #41070 Test Plan: Ran `yarn test-typescript` and `yarn test-typescript-offline` and there were no errors. Reviewed By: rshest Differential Revision: D50451318 Pulled By: javache fbshipit-source-id: a0fceba270dbb80383cceb16f7719252a05b62b5
1 parent c068071 commit bc16bc5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/react-native/Libraries/Components/View/ViewPropTypes.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ export interface ViewProps
184184
* the Z-index of sibling views always takes precedence if a touch
185185
* hits two overlapping views.
186186
*/
187-
hitSlop?: Insets | undefined;
187+
hitSlop?: null | Insets | number | undefined;
188188

189189
/**
190190
* Used to reference react managed views from native code.

0 commit comments

Comments
 (0)