Skip to content

Commit

Permalink
Delete concept of live reloading
Browse files Browse the repository at this point in the history
Summary:
Live reloading has been deprecated in favor of fast refresh for years, this diff removes remaining references to it.

Changelog: [iOS] Delete deprecated "live reloading" setting

Reviewed By: fkgozali

Differential Revision: D26983596

fbshipit-source-id: c7f86e7ec511f80e53659bccd8f40ac4f0cac27c
  • Loading branch information
Peter Argany authored and facebook-github-bot committed Mar 12, 2021
1 parent 0afba0e commit b512beb
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 21 deletions.
2 changes: 0 additions & 2 deletions React/Base/RCTBundleURLProvider.h
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,6 @@ extern const NSUInteger kRCTBundleURLProviderDefaultPort;
* The IP address or hostname of the packager.
*/
@property (nonatomic, copy) NSString *jsLocation;

@property (nonatomic, assign) BOOL enableLiveReload;
@property (nonatomic, assign) BOOL enableMinification;
@property (nonatomic, assign) BOOL enableDev;

Expand Down
14 changes: 0 additions & 14 deletions React/Base/RCTBundleURLProvider.mm
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@
const NSUInteger kRCTBundleURLProviderDefaultPort = RCT_METRO_PORT;

static NSString *const kRCTJsLocationKey = @"RCT_jsLocation";
// This option is no longer exposed in the dev menu UI.
// It was renamed in D15958697 so it doesn't get stuck with no way to turn it off:
static NSString *const kRCTEnableLiveReloadKey = @"RCT_enableLiveReload_LEGACY";
static NSString *const kRCTEnableDevKey = @"RCT_enableDev";
static NSString *const kRCTEnableMinificationKey = @"RCT_enableMinification";

Expand All @@ -35,7 +32,6 @@ - (instancetype)init
- (NSDictionary *)defaults
{
return @{
kRCTEnableLiveReloadKey : @NO,
kRCTEnableDevKey : @YES,
kRCTEnableMinificationKey : @NO,
};
Expand Down Expand Up @@ -275,11 +271,6 @@ - (BOOL)enableDev
return [[NSUserDefaults standardUserDefaults] boolForKey:kRCTEnableDevKey];
}

- (BOOL)enableLiveReload
{
return [[NSUserDefaults standardUserDefaults] boolForKey:kRCTEnableLiveReloadKey];
}

- (BOOL)enableMinification
{
return [[NSUserDefaults standardUserDefaults] boolForKey:kRCTEnableMinificationKey];
Expand All @@ -295,11 +286,6 @@ - (void)setEnableDev:(BOOL)enableDev
[self updateValue:@(enableDev) forKey:kRCTEnableDevKey];
}

- (void)setEnableLiveReload:(BOOL)enableLiveReload
{
[self updateValue:@(enableLiveReload) forKey:kRCTEnableLiveReloadKey];
}

- (void)setJsLocation:(NSString *)jsLocation
{
[self updateValue:jsLocation forKey:kRCTJsLocationKey];
Expand Down
5 changes: 0 additions & 5 deletions React/CoreModules/RCTDevMenu.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ RCT_EXTERN NSString *const RCTShowDevMenuNotification;
*/
@property (nonatomic, assign) BOOL profilingEnabled DEPRECATED_ATTRIBUTE;

/**
* Deprecated, use RCTDevSettings instead.
*/
@property (nonatomic, assign) BOOL liveReloadEnabled DEPRECATED_ATTRIBUTE;

/**
* Deprecated, use RCTDevSettings instead.
*/
Expand Down

0 comments on commit b512beb

Please sign in to comment.