Skip to content

Commit b4fd178

Browse files
kelsetfacebook-github-bot
authored andcommitted
fix(dependencies): move mockfs to the right package.json (#35476)
Summary: While working on 0.71 we noticed that we were hitting a "mock-fs not found" issue on CI, caused by the fact that the dependency was set in the wrong spot. This PR backports to main the fix: 05646f8 & ceaebc6 This is related to the black magics of repo-config, and the fact that devDeps from repo-config don't get propagated back to the root package.json when on stable branch. Because of that, this commit doesn't NOT have a yarn.lock entry (the dep is there in main). I'm confused as to how that dep ended in the devDeps of repo config, it seems something went wrong in migrating some commits from GH to monorepo and back? check out: * #34580 * f0ffd22 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - move mockfs to the right package.json Pull Request resolved: #35476 Test Plan: N/A, change is transparent Reviewed By: cortinico, cipolleschi, dmytrorykun Differential Revision: D41530265 Pulled By: jacdebug fbshipit-source-id: ec7a6426d9a2a766a98a3cccc339ca7ca090c3a0
1 parent e6c0ac0 commit b4fd178

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@
145145
"devDependencies": {
146146
"flow-bin": "^0.193.0",
147147
"hermes-eslint": "0.8.0",
148+
"mock-fs": "^5.1.4",
148149
"react": "18.2.0",
149150
"react-test-renderer": "^18.2.0"
150151
},

repo-config/package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,5 @@
5454
"typescript": "4.1.3",
5555
"ws": "^6.2.2",
5656
"yargs": "^17.5.1"
57-
},
58-
"devDependencies": {
59-
"mock-fs": "^5.1.4"
6057
}
6158
}

0 commit comments

Comments
 (0)