Remove deprecation of onCatalystInstanceDestroy (#40777)

Summary:
Pull Request resolved: #40777

In this diff I'm removing the deprecation of NativeModule.onCatalystInstanceDestroy() method, changing it to DeprecatedInNewArchitecture

changelog: [Android][Breaking] Mark NativeModule.onCatalystInstanceDestroy() method as deprecated in new architecture

Reviewed By: christophpurrer

Differential Revision: D50141027

fbshipit-source-id: a4c4911bdadc27f981f3af0522317e6dd08d9344

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeModule.java

@@ -52,7 +52,7 @@ interface NativeMethod {
    *
    * @deprecated use {@link #invalidate()} instead.
    */
-  @Deprecated(since = "Use invalidate method instead", forRemoval = true)
+  @DeprecatedInNewArchitecture(message = "Use invalidate method instead")
   void onCatalystInstanceDestroy();
 
   /** Allow NativeModule to clean up. Called before React Native instance is destroyed. */