Skip to content

Commit

Permalink
Do not add "Copy Hermes Framework" script phase to hermes-engine target
Browse files Browse the repository at this point in the history
Summary:
This script phase is added to the main target of the user project.
Adding it to the hermes-engine target is redundant and does nothing useful.

Changelog:
[iOS][Changed] - Do not add "Copy Hermes Framework" script phase to hermes-engine target.

Reviewed By: cipolleschi

Differential Revision: D41521276

fbshipit-source-id: a024fa33f7ec1605d1d6021f436d3d397871a50c
  • Loading branch information
dmytrorykun authored and facebook-github-bot committed Nov 24, 2022
1 parent db3ac93 commit af6c9e2
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions sdks/hermes-engine/hermes-engine.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,6 @@ Pod::Spec.new do |spec|
export CMAKE_BINARY=${CMAKE_BINARY:-#{%x(command -v cmake | tr -d '\n')}}
. ${REACT_NATIVE_PATH}/sdks/hermes-engine/utils/build-hermes-xcode.sh #{version} #{hermesc_path}/ImportHermesc.cmake
EOS
},
{
:name => 'Copy Hermes Framework',
:script => ". ${REACT_NATIVE_PATH}/sdks/hermes-engine/utils/copy-hermes-xcode.sh"
}
]
end
Expand Down

0 comments on commit af6c9e2

Please sign in to comment.