Skip to content

Commit

Permalink
Allow overflow scroll to clip the view instead of let it be visible
Browse files Browse the repository at this point in the history
Summary:
When the overflow style set to 'scroll', React ViewGroup does nothing to the container. Instead it should be clipped just like hidden.

Changelog:
[Android][Changed] - Setting `overflow: scroll` in View component style will clip the children in the View container

Reviewed By: javache

Differential Revision: D31350605

fbshipit-source-id: e0d618f5e872fec9cf9ecb2d4cfe7af9a2f3c063
  • Loading branch information
ryancat authored and facebook-github-bot committed Oct 5, 2021
1 parent 36f3bf2 commit 93beb83
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -786,6 +786,7 @@ private void dispatchOverflowDraw(Canvas canvas) {
}
break;
case ViewProps.HIDDEN:
case ViewProps.SCROLL:
float left = 0f;
float top = 0f;
float right = getWidth();
Expand Down

0 comments on commit 93beb83

Please sign in to comment.