-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: added enterKeyHint prop to textInput (#34482)
Summary: This adds the `enterKeyHint` prop to the TextInput component as requested on #34424, mapping web [enterKeyHint types](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/enterkeyhint) to equivalent [returnKeyType](https://reactnative.dev/docs/textinput#returnkeytype) values. This PR also updates RNTester TextInputExample in order to facilitate the manual QA. ## Open questions - What should be the `returnType` in the case of `previous` in iOS? - what should happen if `enterKeyHint` and `returnKeyType` props are passed together? ## Changelog [General] [Added] - Add enterKeyHint prop to TextInput component Pull Request resolved: #34482 Test Plan: - Open the RNTester app and navigate to the TextInput page - Test the TextInput component through the `enterKeyHint modes section` <image src="https://user-images.githubusercontent.com/22423684/186191205-9c04732e-568c-4cce-9564-50a84d70dca3.png" height="600px" width="300px" /> Reviewed By: GijsWeterings Differential Revision: D38957275 Pulled By: necolas fbshipit-source-id: d75f2c2000df5d9606a005083b20bf3a23b48831
- Loading branch information
1 parent
38e1e25
commit 8c882b4
Showing
2 changed files
with
62 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters