-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: Pull Request resolved: #35063 This is part of a series of tasks to make the React Native Gradle Plugin (RNGP) variant-aware. Here I'm add Variant support to RNGP via the Variant API from AGP 7.x A short summary of changes: - I've pushed a number of breaking changes to ReactExtension (we should document them in the release notes). Specifically I've removed properties which I believe were unnecessary and confusing - I've removed all the extra logic to do the .so cleanups and use the new tasks that use the Artifacts API - I've introduced only a `debuggableVariants` to make all the decisions for the bundling and minification which should be sufficient for users - I've removed all the funcional interfaces are replaced them with lists as they're easy to handle and understand for users. Changelog: [Android] [Changed] - Added Flavor Support to React Native Gradle Plugin (RNGP) Reviewed By: cipolleschi Differential Revision: D40335028 fbshipit-source-id: d9ac1437de8a27db2e93df15b13772b221e036b2
- Loading branch information
1 parent
2cc2ca1
commit 8ad86c7
Showing
6 changed files
with
96 additions
and
466 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
8ad86c7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cortinico
error log
complete debug log
The previous commit builds with patch f8cd9f1
8ad86c7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up @fabriziobertoglio1987
The fix for this is here:
#35093