Skip to content

Commit 8881faa

Browse files
javachefacebook-github-bot
authored andcommitted
Rollout useRawPropsJsiValue (#53426)
Summary: Pull Request resolved: #53426 Experiment review for this was completed internally, and we can now change the default behaviour to no longer allocate an intermediate folly::dynamic when parsing props. RawValue will continue supporting a folly::dynamic constructor as some paths go through code path (eg animations) There should be no user-visible difference in parsing behaviour. Changelog: [Internal] Reviewed By: rshest Differential Revision: D80799833 fbshipit-source-id: 8eeae656157757eb38f69a2af14409da23b510c8
1 parent b054540 commit 8881faa

File tree

4 files changed

+8
-9
lines changed

4 files changed

+8
-9
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<3c47ba9c7fdbb37f0e06fdca56de3223>>
7+
* @generated SignedSource<<2daac10f81c205728db8127da4dd36cc>>
88
*/
99

1010
/**
@@ -149,7 +149,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
149149

150150
override fun useOptimizedEventBatchingOnAndroid(): Boolean = false
151151

152-
override fun useRawPropsJsiValue(): Boolean = false
152+
override fun useRawPropsJsiValue(): Boolean = true
153153

154154
override fun useShadowNodeStateOnClone(): Boolean = false
155155

packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<30170e483b919c7bd235bfcfe4174c39>>
7+
* @generated SignedSource<<47b7dd2d84a9ea6c2e89677ac5b5554e>>
88
*/
99

1010
/**
@@ -280,7 +280,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
280280
}
281281

282282
bool useRawPropsJsiValue() override {
283-
return false;
283+
return true;
284284
}
285285

286286
bool useShadowNodeStateOnClone() override {

packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -719,13 +719,12 @@ const definitions: FeatureFlagDefinitions = {
719719
ossReleaseStage: 'none',
720720
},
721721
useRawPropsJsiValue: {
722-
defaultValue: false,
722+
defaultValue: true,
723723
metadata: {
724-
dateAdded: '2024-12-02',
725724
description:
726725
'Instead of using folly::dynamic as internal representation in RawProps and RawValue, use jsi::Value',
727726
expectedReleaseValue: true,
728-
purpose: 'experimentation',
727+
purpose: 'release',
729728
},
730729
ossReleaseStage: 'none',
731730
},

packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<6ec32c21e134bd51702d7fcab094c725>>
7+
* @generated SignedSource<<cb505b80eebdf982b88aebf4c37843da>>
88
* @flow strict
99
* @noformat
1010
*/
@@ -436,7 +436,7 @@ export const useOptimizedEventBatchingOnAndroid: Getter<boolean> = createNativeF
436436
/**
437437
* Instead of using folly::dynamic as internal representation in RawProps and RawValue, use jsi::Value
438438
*/
439-
export const useRawPropsJsiValue: Getter<boolean> = createNativeFlagGetter('useRawPropsJsiValue', false);
439+
export const useRawPropsJsiValue: Getter<boolean> = createNativeFlagGetter('useRawPropsJsiValue', true);
440440
/**
441441
* Use the state stored on the source shadow node when cloning it instead of reading in the most recent state on the shadow node family.
442442
*/

0 commit comments

Comments
 (0)