Skip to content

Commit

Permalink
Fix ESLint and Typescript-ESLint disagreeing about function spacing (#…
Browse files Browse the repository at this point in the history
…33453)

Summary:
Fixes #33452 by replacing deprecated no-spaced-func ESLint rule and adding related TypeScript.

Changelog: [General][Fixed] - Update function spacing linting rules

See #33452 - Existing function spacing linting should pass as expected.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->

[CATEGORY] [TYPE] - Message

Pull Request resolved: #33453

Reviewed By: lunaleaps, cortinico

Differential Revision: D35011944

Pulled By: GijsWeterings

fbshipit-source-id: 441650045d89a01a9114103da0c080643f9cb82c
  • Loading branch information
joeframbach authored and facebook-github-bot committed Apr 1, 2022
1 parent 864a8c1 commit 8650220
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion packages/eslint-config-react-native-community/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ module.exports = {
'no-shadow': 'off',
'@typescript-eslint/no-shadow': 1,
'no-undef': 'off',
'func-call-spacing': 'off',
'@typescript-eslint/func-call-spacing': 1,
},
},
{
Expand Down Expand Up @@ -257,7 +259,7 @@ module.exports = {
'no-empty-character-class': 1, // disallow the use of empty character classes in regular expressions
'no-lonely-if': 0, // disallow if as the only statement in an else block (off by default)
'no-new-object': 1, // disallow use of the Object constructor
'no-spaced-func': 1, // disallow space between function identifier and application
'func-call-spacing': 1, // disallow space between function identifier and application
'no-ternary': 0, // disallow the use of ternary operators (off by default)
'no-trailing-spaces': 1, // disallow trailing whitespace at the end of lines
'no-underscore-dangle': 0, // disallow dangling underscores in identifiers
Expand Down

0 comments on commit 8650220

Please sign in to comment.