Skip to content

Commit 8414427

Browse files
gabrieldonadelLuna Wei
authored andcommitted
Fix ios pod post_install logic for detecting if fabric is enabled (#41284)
Summary: There is a problem in the way that we check if Fabric is enabled inside `react_native_post_install`. https://github.com/facebook/react-native/blob/899e7cdb55197fc17a96a93af4f8bcc7519553c2/packages/react-native/scripts/react_native_pods.rb#L239 We're determining if fabric is enabled by checking if the `React-Fabric pod `is present, but since we always call `setup_fabric!(:react_native_path => prefix)` (#39057) inside `use_react_native` the `React-Fabric` pod is always present causing the `-DRN_FABRIC_ENABLED` flag to always be added to `project.pbxproj` even if the new arch is disabled. [IOS] [FIXED] - Fix ios pod post_install logic for detecting if fabric is enabled Pull Request resolved: #41284 Test Plan: Run `use_react_native!(fabric => false)` should not add the `-DRN_FABRIC_ENABLED` flag to `project.pbxproj` Reviewed By: fkgozali Differential Revision: D50896487 Pulled By: cipolleschi fbshipit-source-id: 78154407ce52b09fd3a317b7dc64bd4bba56363e
1 parent 9b97cd9 commit 8414427

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/react-native/scripts/react_native_pods.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ def react_native_post_install(
258258
flipper_post_install(installer)
259259
end
260260

261-
fabric_enabled = ReactNativePodsUtils.has_pod(installer, 'React-Fabric')
261+
fabric_enabled = ENV['RCT_FABRIC_ENABLED'] == '1'
262262
hermes_enabled = ReactNativePodsUtils.has_pod(installer, "React-hermes")
263263

264264
if hermes_enabled

0 commit comments

Comments
 (0)