Commit 80e5abd
Fix Android border positioning regression (#32398)
Summary:
#29099 introduced a regression where non-rounded borders on Android would render partly outside of the bounds of the view as I reported in #32393. This PR addresses that by rendering the borders completely inside the view like it works on iOS, previous version of RN and for rounded corners.
## Changelog
<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->
[Android] [Fixed] - Fix Android border positioning regression
Pull Request resolved: #32398
Test Plan:
Rendering the following code (as reported in the issue) in the RN Tester app:
```jsx
<View
style={{
aspectRatio: 1,
backgroundColor: 'green',
borderWidth: 8,
borderColor: 'black',
borderStyle: 'dashed',
}}
/>
```
|Before|After|
|--|--|
|||
Reviewed By: yungsters
Differential Revision: D31623647
Pulled By: lunaleaps
fbshipit-source-id: c38d172ae4a9dc48f800c63258223a59e2f621ed1 parent e94f9fa commit 80e5abd
File tree
1 file changed
+8
-8
lines changed- ReactAndroid/src/main/java/com/facebook/react/views/view
1 file changed
+8
-8
lines changedLines changed: 8 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1106 | 1106 | | |
1107 | 1107 | | |
1108 | 1108 | | |
1109 | | - | |
1110 | | - | |
| 1109 | + | |
| 1110 | + | |
1111 | 1111 | | |
1112 | 1112 | | |
1113 | 1113 | | |
1114 | 1114 | | |
1115 | 1115 | | |
1116 | 1116 | | |
1117 | 1117 | | |
1118 | | - | |
1119 | | - | |
| 1118 | + | |
| 1119 | + | |
1120 | 1120 | | |
1121 | 1121 | | |
1122 | 1122 | | |
1123 | 1123 | | |
1124 | 1124 | | |
1125 | 1125 | | |
1126 | 1126 | | |
1127 | | - | |
1128 | | - | |
| 1127 | + | |
| 1128 | + | |
1129 | 1129 | | |
1130 | 1130 | | |
1131 | 1131 | | |
1132 | 1132 | | |
1133 | 1133 | | |
1134 | 1134 | | |
1135 | 1135 | | |
1136 | | - | |
1137 | | - | |
| 1136 | + | |
| 1137 | + | |
1138 | 1138 | | |
1139 | 1139 | | |
1140 | 1140 | | |
| |||
0 commit comments