Skip to content

Commit

Permalink
setNSAllowsArbitraryLoads to false by default in template (#28885)
Browse files Browse the repository at this point in the history 
Summary:
Since we already have `localhost` as`Exception Domains` in NSAppTransportSecurity to allow connect to dev server, the template should set `NSAllowsArbitraryLoads` to false by default, as exaplained in [Apple's document](https://developer.apple.com/documentation/bundleresources/information_property_list/nsapptransportsecurity/nsallowsarbitraryloads) as a good practice.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->

[iOS] [enhancement] - set `NSAllowsArbitraryLoads` to `false` by default in template
Pull Request resolved: #28885

Differential Revision: D21624042

Pulled By: shergin

fbshipit-source-id: 690afcd037c3f328d293ef4475380a28efd9fee6
  • Loading branch information
@wddwycc @facebook-github-bot
wddwycc authored and facebook-github-bot committed May 18, 2020
1 parent 8ac467c commit 7b61a96
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions template/ios/HelloWorld/Info.plist
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@
<true/>
<key>NSAppTransportSecurity</key>
<dict>
<key>NSAllowsArbitraryLoads</key>
<true/>
<key>NSExceptionDomains</key>
<dict>
<key>localhost</key>
Expand Down

0 comments on commit 7b61a96

Please sign in to comment.