Adding support for resource-id.

* This closes #9777.
facebook · Sep 19, 2016 · 62f66db · 62f66db
1 parent 7b2080e
commit 62f66db
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java
@@ -9,6 +9,7 @@
 
 import com.facebook.react.bridge.ReadableArray;
 import com.facebook.react.uimanager.annotations.ReactProp;
+import java.util.concurrent.ConcurrentHashMap;
 
 /**
  * Base class that should be suitable for the majority of subclasses of {@link ViewManager}.
@@ -35,6 +36,8 @@ public abstract class BaseViewManager<T extends View, C extends LayoutShadowNode
   private static final String PROP_TRANSLATE_X = "translateX";
   private static final String PROP_TRANSLATE_Y = "translateY";
 
+  private static final ConcurrentHashMap<String, Integer> TEST_IDS = new ConcurrentHashMap<>();
+
   /**
    * Used to locate views in end-to-end (UI) tests.
    */
@@ -84,6 +87,13 @@ public void setRenderToHardwareTexture(T view, boolean useHWTexture) {
 
   @ReactProp(name = PROP_TEST_ID)
   public void setTestId(T view, String testId) {
+    if (!TEST_IDS.containsKey(testId)) {
+      TEST_IDS.put(testId, view.getResources().getIdentifier(testId, "id", view.getContext().getPackageName()));
+    }
+    int mappedTestId = TEST_IDS.get(testId);
+    if (mappedTestId != 0 && view.getId() == View.NO_ID) {
+      view.setId(mappedTestId);
+    }
     view.setTag(testId);
   }