Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix a bug for which is impossible to disable Hermes (#34142)
Summary: Pull Request resolved: #34142 The `||=` operator in an expression like `x = a ||= b` works in a way that: - if a is null, it assigns b to x - if a is `falsy`, it assigns b to x - otherwise, it assigns a to x. In our setup, if the user set `hermes_enabled` to `false` in the Podfile (one of the suggested way to disabled Hermes), the `options[:hermes_enabled]` part will evaluate to false and, therefore, `hermes_enabled` will obtain the value of `true`. ## Changelog [iOS][Changed] - Use the correct operator to decide whether Hermes is enabled or not. Reviewed By: cortinico Differential Revision: D37643845 fbshipit-source-id: 387f7bd642250c40873400d22d7d85451462c073
- Loading branch information