Fix a crash when reloading the JS bundle

Summary: changelog: [iOS][Fixed] Fix a crash when reloading JS bundle Do not crash if self is nil. Reviewed By: blakef Differential Revision: D43352039 fbshipit-source-id: dd53677ca152d4021e43ed8d0f1b51c071ca3365
facebook · Feb 17, 2023 · 60f381a · 60f381a
1 parent 0b2bd0f
commit 60f381a
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/React/CoreModules/RCTDevSplitBundleLoader.mm b/React/CoreModules/RCTDevSplitBundleLoader.mm
@@ -63,10 +63,12 @@ + (BOOL)requiresMainQueueSetup
             return;
           }
           __typeof(self) strongSelf = weakSelf;
-          strongSelf->_loadScript(source);
-          RCTDevSettings *devSettings = [strongSelf->_moduleRegistry moduleForName:"RCTDevSettings"];
-          [devSettings setupHMRClientWithAdditionalBundleURL:source.url];
-          resolve(@YES);
+          if (strongSelf) {
+            strongSelf->_loadScript(source);
+            RCTDevSettings *devSettings = [strongSelf->_moduleRegistry moduleForName:"RCTDevSettings"];
+            [devSettings setupHMRClientWithAdditionalBundleURL:source.url];
+            resolve(@YES);
+          }
         }];
   }
 }