Skip to content

Commit

Permalink
Add ld_classic flag to Hermes when building for Xcode 15 (#39516)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #39516

With Xcode15, Apple rewrote the C++ linker.
This is a breaking change that does not work with weak symbols.
As a workaround, apple is suggesting to add `-ld_classic` to the linker in order to readd support for weak symbols. The flag does not exists for Xcode 14.3 or lower, so we need to add it conditionally.

With this change, we introduce a couple of checks in the Hermes build logic:
1. Detect the version of Xcode that is used
2. Add the new flag to `HERMES_EXTRA_LINKER_FLAGS` if Xcode version is 15.

[Internal] - Make hermes build properly with Xcode 15

Reviewed By: cortinico, dmytrorykun

Differential Revision: D49368675

fbshipit-source-id: 62d8ed81855c426f56ed94b6a2d6da2eb882b355
  • Loading branch information
cipolleschi authored and Titozzz committed Sep 19, 2023
1 parent 740c401 commit 5f4a091
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion sdks/hermes-engine/utils/build-apple-framework.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ function build_host_hermesc {

# Utility function to configure an Apple framework
function configure_apple_framework {
local build_cli_tools enable_bitcode
local build_cli_tools enable_bitcode xcode_15_flags xcode_major_version

if [[ $1 == iphoneos || $1 == catalyst ]]; then
enable_bitcode="true"
Expand All @@ -48,7 +48,14 @@ function configure_apple_framework {
build_cli_tools="false"
fi

xcode_15_flags=""
xcode_major_version=$(xcodebuild -version | grep -oE '[0-9]*' | head -n 1)
if [[ $xcode_major_version -ge 15 ]]; then
xcode_15_flags="LINKER:-ld_classic"
fi

cmake -S . -B "build_$1" \
-DHERMES_EXTRA_LINKER_FLAGS="$xcode_15_flags" \
-DHERMES_APPLE_TARGET_PLATFORM:STRING="$1" \
-DCMAKE_OSX_ARCHITECTURES:STRING="$2" \
-DCMAKE_OSX_DEPLOYMENT_TARGET:STRING="$3" \
Expand Down

0 comments on commit 5f4a091

Please sign in to comment.