From 4e4b9e2111faaf5652ae1f5b885730b378f3de98 Mon Sep 17 00:00:00 2001 From: Dmitry Rykun Date: Thu, 9 Jun 2022 02:39:54 -0700 Subject: [PATCH] Fix reatain cycle RCTPullToRefreshViewComponentView <-> RCTScrollViewComponentView Summary: Changelog: [iOS][Fixed] - `_scrollViewComponentView` is set to `RCTPullToRefreshViewComponentView's` superview: ``` _scrollViewComponentView = [RCTScrollViewComponentView findScrollViewComponentViewForView:self]; ``` It should be safe to make it weak. Reviewed By: javache Differential Revision: D36998626 fbshipit-source-id: 2130b743d181e15986cb68636d60507a986968e1 --- .../ScrollView/RCTPullToRefreshViewComponentView.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/React/Fabric/Mounting/ComponentViews/ScrollView/RCTPullToRefreshViewComponentView.mm b/React/Fabric/Mounting/ComponentViews/ScrollView/RCTPullToRefreshViewComponentView.mm index 325b0a042c19ed..b897d8a8e8b0c8 100644 --- a/React/Fabric/Mounting/ComponentViews/ScrollView/RCTPullToRefreshViewComponentView.mm +++ b/React/Fabric/Mounting/ComponentViews/ScrollView/RCTPullToRefreshViewComponentView.mm @@ -25,7 +25,7 @@ @interface RCTPullToRefreshViewComponentView ()