Fix reatain cycle RCTPullToRefreshViewComponentView <-> RCTScrollViewComponentView

Dmitry Rykun · facebook-github-bot · commit 4e4b9e2111fa · 2022-06-09T02:39:54.000-07:00
Summary:
Changelog: [iOS][Fixed] - `_scrollViewComponentView` is set to `RCTPullToRefreshViewComponentView's` superview:
```
_scrollViewComponentView = [RCTScrollViewComponentView findScrollViewComponentViewForView:self];
```
It should be safe to make it weak.

Reviewed By: javache

Differential Revision: D36998626

fbshipit-source-id: 2130b743d181e15986cb68636d60507a986968e1
diff --git a/React/Fabric/Mounting/ComponentViews/ScrollView/RCTPullToRefreshViewComponentView.mm b/React/Fabric/Mounting/ComponentViews/ScrollView/RCTPullToRefreshViewComponentView.mm
@@ -25,7 +25,7 @@ @interface RCTPullToRefreshViewComponentView () <RCTPullToRefreshViewViewProtoco
 
 @implementation RCTPullToRefreshViewComponentView {
   UIRefreshControl *_refreshControl;
-  RCTScrollViewComponentView *_scrollViewComponentView;
+  RCTScrollViewComponentView *__weak _scrollViewComponentView;
 }
 
 - (instancetype)initWithFrame:(CGRect)frame

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ @interface RCTPullToRefreshViewComponentView () <RCTPullToRefreshViewViewProtoco`
`25`	`25`
`26`	`26`	`@implementation RCTPullToRefreshViewComponentView {`
`27`	`27`	`UIRefreshControl *_refreshControl;`
`28`		`- RCTScrollViewComponentView *_scrollViewComponentView;`
	`28`	`+ RCTScrollViewComponentView *__weak _scrollViewComponentView;`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`- (instancetype)initWithFrame:(CGRect)frame`