Skip to content

Commit 499b021

Browse files
rickhanloniifacebook-github-bot
authored andcommitted
Backout React Sync again
Summary: Revert the react sync. Changelog: [Internal] Reviewed By: kacieb Differential Revision: D22994588 fbshipit-source-id: 9662723839389465615bff2fdcf2759fb85bcb75
1 parent 471c2eb commit 499b021

13 files changed

+34761
-38479
lines changed

Libraries/LogBox/__tests__/LogBox-integration-test.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,7 @@ const cleanLog = logs => {
4949
});
5050
};
5151

52-
// TODO(T71117418): Re-enable skipped LogBox integration tests once React component
53-
// stack frames are the same internally and in open source.
54-
// eslint-disable-next-line jest/no-disabled-tests
55-
describe.skip('LogBox', () => {
52+
describe('LogBox', () => {
5653
const {error, warn} = console;
5754
const mockError = jest.fn();
5855
const mockWarn = jest.fn();
Lines changed: 94 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,94 @@
1+
// Jest Snapshot v1, https://goo.gl/fbAQLP
2+
3+
exports[`LogBox integrates with React and handles a fragment warning in LogBox: Log added to LogBox 1`] = `
4+
Array [
5+
Object {
6+
"category": "Warning: Invalid prop \`%s\` supplied to \`React.Fragment\`. React.Fragment can only have \`key\` and \`children\` props.",
7+
"componentStack": Array [
8+
Object {
9+
"content": "Fragment",
10+
"fileName": "ReactWarningFixtures.js",
11+
"location": Object {
12+
"column": -1,
13+
"row": 28,
14+
},
15+
},
16+
],
17+
"level": "warn",
18+
"message": Object {
19+
"content": "Warning: Invalid prop \`invalid\` supplied to \`React.Fragment\`. React.Fragment can only have \`key\` and \`children\` props.",
20+
"substitutions": Array [
21+
Object {
22+
"length": 7,
23+
"offset": 23,
24+
},
25+
],
26+
},
27+
},
28+
]
29+
`;
30+
31+
exports[`LogBox integrates with React and handles a fragment warning in LogBox: Log passed to console error 1`] = `
32+
Array [
33+
"Warning: Invalid prop \`invalid\` supplied to \`React.Fragment\`. React.Fragment can only have \`key\` and \`children\` props.
34+
in Fragment (at ReactWarningFixtures.js:28)",
35+
]
36+
`;
37+
38+
exports[`LogBox integrates with React and handles a fragment warning in LogBox: Log sent from React 1`] = `
39+
Array [
40+
"Warning: Invalid prop \`%s\` supplied to \`React.Fragment\`. React.Fragment can only have \`key\` and \`children\` props.%s",
41+
"invalid",
42+
"
43+
in Fragment (at ReactWarningFixtures.js:28)",
44+
]
45+
`;
46+
47+
exports[`LogBox integrates with React and handles a key error in LogBox: Log added to LogBox 1`] = `
48+
Array [
49+
Object {
50+
"category": "Warning: Each child in a list should have a unique \\"key\\" prop.%s%s See https://fb.me/react-warning-keys for more information.",
51+
"componentStack": Array [
52+
Object {
53+
"content": "Text",
54+
"fileName": "ReactWarningFixtures.js",
55+
"location": Object {
56+
"column": -1,
57+
"row": 20,
58+
},
59+
},
60+
],
61+
"level": "warn",
62+
"message": Object {
63+
"content": "Warning: Each child in a list should have a unique \\"key\\" prop. See https://fb.me/react-warning-keys for more information.",
64+
"substitutions": Array [
65+
Object {
66+
"length": 0,
67+
"offset": 62,
68+
},
69+
Object {
70+
"length": 0,
71+
"offset": 62,
72+
},
73+
],
74+
},
75+
},
76+
]
77+
`;
78+
79+
exports[`LogBox integrates with React and handles a key error in LogBox: Log passed to console error 1`] = `
80+
Array [
81+
"Warning: Each child in a list should have a unique \\"key\\" prop. See https://fb.me/react-warning-keys for more information.
82+
in Text (at ReactWarningFixtures.js:20)",
83+
]
84+
`;
85+
86+
exports[`LogBox integrates with React and handles a key error in LogBox: Log sent from React 1`] = `
87+
Array [
88+
"Warning: Each child in a list should have a unique \\"key\\" prop.%s%s See https://fb.me/react-warning-keys for more information.%s",
89+
"",
90+
"",
91+
"
92+
in Text (at ReactWarningFixtures.js:20)",
93+
]
94+
`;

Libraries/Renderer/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
e67a6b16030ebc30257a69a7fb36a9ed67f29b39
1+
b5c6dd2de557428974855b5aa88bf9c6595beb2b

0 commit comments

Comments
 (0)