Skip to content

Commit 4094793

Browse files
kelsetpull[bot]
authored andcommitted
infra(e2e): fix enabling new arch for RNTester iOS in the E2E script (#34882)
Summary: Quick follow up to #34513 to fix an issue that has been bothering the release crew for a while: the iOS new arch component not working! Turns out, we're silly billies � ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - Add new arch flag to iOS pod install command in E2E script Pull Request resolved: #34882 Test Plan: Everything works correctly now: <img width="987" alt="Screenshot 2022-10-06 at 14 20 09" src="https://user-images.githubusercontent.com/16104054/194327768-4da7d607-879b-46ad-a453-504983980831.png"> Reviewed By: dmytrorykun Differential Revision: D40143251 Pulled By: dmytrorykun fbshipit-source-id: 91ba6e22c25770efe6a839d6728d7052bc17a8f2
1 parent 2f7966e commit 4094793

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

scripts/test-e2e-local.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,12 @@ if (argv.target === 'RNTester') {
7474
console.info(
7575
`We're going to test the ${
7676
argv.hermes ? 'Hermes' : 'JSC'
77-
} version of RNTester iOS`,
77+
} version of RNTester iOS with the new Architecture enabled`,
7878
);
7979
exec(
8080
`cd packages/rn-tester && USE_HERMES=${
8181
argv.hermes ? 1 : 0
82-
} bundle exec pod install --ansi`,
82+
} RCT_NEW_ARCH_ENABLED=1 bundle exec pod install --ansi`,
8383
);
8484

8585
// if everything succeeded so far, we can launch Metro and the app
@@ -98,7 +98,7 @@ if (argv.target === 'RNTester') {
9898
console.info(
9999
`We're going to test the ${
100100
argv.hermes ? 'Hermes' : 'JSC'
101-
} version of RNTester Android`,
101+
} version of RNTester Android with the new Architecture enabled`,
102102
);
103103
exec(
104104
`./gradlew :packages:rn-tester:android:app:${

0 commit comments

Comments
 (0)